Don't extraneously include the hostname on links to workshops for emails #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍👍👍👍👍 |
|
Pulling into development while tests are running, I'll update and verify on our staging site. |
|
Merged into master, kicking off a prod build now |
|
Built and bounced. As a test, I'm going to save the Spanish translation of your workshop again which should re-send you that email. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got an email notification about a translation for a workshop I'm leading which included the link below:
That URL doesn't work as it includes the hostname twice.
Attached is a PR which should fix this here, and in other email templates that featured a similar function call.