Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove internal build process #571

Merged
merged 1 commit into from
Jan 18, 2024
Merged

feat: remove internal build process #571

merged 1 commit into from
Jan 18, 2024

Conversation

dianjuar
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What is the current behavior?

Remove the built-in build process in favor of dependsOn Nx feature. Add support for libraries that doesn't require build process.

This PR should close:

#553, #516
#445, #444, #443, #442, #441, #440, #439, #438, #437, #415
#74

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Here, you can find a more detailed explanation of the changes introduced in V8.

https://dev.to/dianjuar/whats-coming-to-ngx-deploy-npm-v8-23gn

Deprecate the built-in build process in favor of `dependsOn` Nx feature.
Add support for libraries that doesn't require build process.

BREAKING CHANGE:
 - `ngx-deploy-npm:install`: Added `--dist-folder-path` option as
required.
 - `ngx-deploy-npm:install`: Drop the option `--projects`, now, each project needs to be specified
independently using `--project`.
 - `ngx-deploy-npm:deploy`: `distFolderPath` option is now required.
 - `ngx-deploy-npm:deploy`: Remove options `noBuild` and `buildTarget`.
Copy link

sonarcloud bot commented Jan 18, 2024

@dianjuar dianjuar merged commit afa228c into main Jan 18, 2024
12 checks passed
@dianjuar dianjuar deleted the remove-internal-build branch January 18, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant