feat!: remove internal build process #527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dianjuar
force-pushed
the
no-buildable-libs
branch
5 times, most recently
from
d84e6c1 to
02b7ccb
Compare
dianjuar
commented
Aug 29, 2023
dianjuar
force-pushed
the
no-buildable-libs
branch
2 times, most recently
from
bae856b to
f245f6f
Compare
dianjuar
commented
Sep 1, 2023
dianjuar
force-pushed
the
no-buildable-libs
branch
from
af3f150 to
6154513
Compare
|
Kudos, SonarCloud Quality Gate passed! |
dianjuar
force-pushed
the
no-buildable-libs
branch
from
831b78e to
c217c33
Compare
dianjuar
force-pushed
the
no-buildable-libs
branch
5 times, most recently
from
d035390 to
1259665
Compare
dianjuar
force-pushed
the
no-buildable-libs
branch
from
a693fbe to
8b3ddb3
Compare
dianjuar
commented
Nov 25, 2023
dianjuar
force-pushed
the
no-buildable-libs
branch
from
277d9ea to
608ca5b
Compare
dianjuar
changed the title
dianjuar
force-pushed
the
no-buildable-libs
branch
2 times, most recently
from
5106182 to
64550f8
Compare
|
SonarCloud Quality Gate failed.
|
dianjuar
force-pushed
the
no-buildable-libs
branch
3 times, most recently
from
e6c10f7 to
c73043c
Compare
dianjuar
force-pushed
the
no-buildable-libs
branch
2 times, most recently
from
8e086de to
1bbde9c
Compare
dianjuar
changed the title
dianjuar
force-pushed
the
no-buildable-libs
branch
from
eae6ef4 to
37359ee
Compare
dianjuar
force-pushed
the
no-buildable-libs
branch
2 times, most recently
from
5c91b06 to
d4af4d7
Compare
dianjuar
force-pushed
the
no-buildable-libs
branch
from
1daa1fa to
1d41395
Compare
dianjuar
force-pushed
the
no-buildable-libs
branch
6 times, most recently
from
16aa81f to
dffb466
Compare
Deprecate the built-in build process in favor of `dependsOn` Nx feature. Add support for libraries that doesn't require build process. BREAKING CHANGE: - `ngx-deploy-npm:install`: Added `--dist-folder-path` option as required. - `ngx-deploy-npm:install`: Drop the option `--projects`, now, each project needs to be specified independently using `--project`. - `ngx-deploy-npm:deploy`: `distFolderPath` option is now required. - `ngx-deploy-npm:deploy`: Remove options `noBuild` and `buildTarget`.
dianjuar
force-pushed
the
no-buildable-libs
branch
from
dffb466 to
faa263b
Compare
|
dianjuar
added a commit
that referenced
this pull request
Jan 16, 2024
Deprecate the built-in build process in favor of `dependsOn` Nx feature. Add support for libraries that doesn't require build process. BREAKING CHANGE: - `ngx-deploy-npm:install`: Added `--dist-folder-path` option as required. - `ngx-deploy-npm:install`: Drop the option `--projects`, now, each project needs to be specified independently using `--project`. - `ngx-deploy-npm:deploy`: `distFolderPath` option is now required. - `ngx-deploy-npm:deploy`: Remove options `noBuild` and `buildTarget`.
dianjuar
added a commit
that referenced
this pull request
Jan 18, 2024
Deprecate the built-in build process in favor of `dependsOn` Nx feature. Add support for libraries that doesn't require build process. BREAKING CHANGE: - `ngx-deploy-npm:install`: Added `--dist-folder-path` option as required. - `ngx-deploy-npm:install`: Drop the option `--projects`, now, each project needs to be specified independently using `--project`. - `ngx-deploy-npm:deploy`: `distFolderPath` option is now required. - `ngx-deploy-npm:deploy`: Remove options `noBuild` and `buildTarget`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
Issue Number: #516 #553
What is the new behavior?
dependsOninstead.deployexecutordistFolderPathoption is now required.buildTargetoption is now removed.noBuildoption is now removed.installgeneratordistFolderPathoption is added and required to specify where the dist folder of the library.projectsoption is removed in favor ofproject. Now, we are allowed to configure a project at a time.distFolderPathis required, it is difficult to provide multipledistFolderPathwhen configuring multiple projects.Does this PR introduce a breaking change?
A migration script is provided for the next version to automate the required changes:
write-dist-folder-path-on-deploy-target-options: Sets the distFolderPath option on the deploy target.distFolderPathis now required.replace-buildtarget-for-depends-on: Remove the optionbuildTargetandnoBuildfrom the deploy target. If the optionbuildTargetwas set, the migration will create a new target to build the library with the desired configuration and create adependsOnon the deploy target to build the library using the just-created target.Other information