Skip to content

fix: set the right peerDependency on ngx-deploy-npm's package.json #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2023

Conversation

dianjuar
Copy link
Member

@dianjuar dianjuar commented Aug 12, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What is the current behavior?

when installing ngx-deploy-npm 7.0.0 the following error occurs:

npm ERR! Found: tslib@2.6.1
npm ERR! node_modules/tslib
npm ERR!   dev tslib@"^2.3.0" from the root project
npm ERR!   tslib@"^2.3.0" from @nx/devkit@16.6.0
npm ERR!   node_modules/@nx/devkit
npm ERR!     peer @nx/devkit@"^16.0.0" from ngx-deploy-npm@7.0.0
npm ERR!     node_modules/ngx-deploy-npm
npm ERR!       dev ngx-deploy-npm@"7.0.0" from the root project
npm ERR!   3 more (nx, @swc-node/register, @swc/helpers)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer tslib@"1.14.1" from ngx-deploy-npm@7.0.0
npm ERR! node_modules/ngx-deploy-npm
npm ERR!   dev ngx-deploy-npm@"7.0.0" from the root project

The option updateBuildableProjectDepsInPackageJson is deprecated, and Nx doesn't automatically update your library's peerDependencies. You need to do it by hand by default.

We implement a semi-automated way of knowing when it's time to update the package's dependencies using an ESLint Rule.

Issue Number:
close #535

What is the new behavior?

Fixes the V7 npm installation error.

The lint process will indicate to us when it's time to update the package's dependencies.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dianjuar dianjuar merged commit 6765f4c into main Aug 12, 2023
@dianjuar dianjuar deleted the fix-wrong-tslint-peerDep branch August 12, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not resolve peer dependency tslib@1.14.1
1 participant