Adding bike infra on the map #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! How does this look? Can you include screenshots at different zoom levels? One thing I've been concerned about here is that "protected bike lane" is so verbose, it might be hard to get it to actually show up, especially now that we show the full street name alongside. We can tweak this too, of course, but I'd just like to make sure "protected bike lane" in particular isn't too verbose to render well. Happy to see a PR by a new contributor, welcome! |
graue
reviewed
Dec 7, 2022
src/components/BikehopperMap.js
Outdated
| @@ -482,20 +482,12 @@ function getLabelTextField() { | |||
| const text = [ | |||
| 'case', | |||
| // Bikeable highways display the type with optional street name | |||
There was a problem hiding this comment.
This comment is worth updating, since you're no longer using the "bikeable highways" list here
since we are no longer converting underscores to spaces this has to change to get the dashed green style for shared roads
I have an idea for how to do this, but I think it makes more sense to do separately and also cover the descriptors shown in the detailed itinerary, such as "very steep hill (max grade 16%), main road".
|
Thanks again for this @shabnomnom! I made some updates and will try to merge it.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #172.
@arindam1993 and I worked on this issue together.
We use the existing
_describeBikeInfraFromCyclewayAndRoadClassfunction from thegeometry.jsto create a newlineStringproperty calledbike_infra. We then injected this property in thegetLabelTextFieldfunction to style the map with thebike_infraproperty instead ofcyclewayandroad_class.