Support lat/long entry and display lat/long for custom pin #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are never treated differently.
Also fix "Current Location" not being translated when in search bar (yikes)
abhumbla
approved these changes
Aug 29, 2024
| @@ -5,13 +5,16 @@ import bezierSpline from '@turf/bezier-spline'; | |||
| import distance from '@turf/distance'; | |||
There was a problem hiding this comment.
any chance we could convert this file to typescript since we're touching it?
There was a problem hiding this comment.
I'm so glad you asked because that dovetails with another branch I'm working on adding types to some itinerary-related files. Not geometry.js yet but it's the natural next one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74.