Fetch region config from API #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andykmcc
approved these changes
Nov 3, 2024
To fix: - Redux type errors deriving from generating the store later than import type (necessary because default viewport bounds aren't fetched yet) - Default viewport being bad for UX, too zoomed out, need manual override
graue
force-pushed
the
graue/region-api
branch
from
dce0c0e to
3f50354
Compare
graue
force-pushed
the
graue/region-api
branch
from
3f50354 to
8e297ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #293.
Fetches region-specific information from an API endpoint, instead of having it hardcoded for the SF Bay in the frontend.
This actually works OK and could be shipped, but before doing so, I would like to figure out how to change the config on the server, and tweak a few things about the API shape.
Up till now, information from the region config has been expected to be available at module import time, which is no longer the case. This is why
lib/regionwill now export getter functions instead of constants, and why the viewport reducer and store initialization have changed slightly.I'm using Zod to ensure the format of the region config is what we expect. Now that we're almost all TypeScript, it would be good to introduce this for other APIs.
To-do list before merging: