Single step view #397
Merged
Single step view #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next: skip the "Arrive at destination" instruction Then: implement for single transit stop view too
Potential improvements:
- Remove the arrive step from the instructions earlier (when first
getting from server) to avoid all this complicated logic later
- OR dress up the arrive steps to make it more obvious you're
transferring to transit
- Add a dressed up arrive at destination step at the very end of the
last leg
|
Feedback
|
|
request:
|
|
This one looks weird without the vertical line. I think I'll keep it for boarding stops.
|
graue
force-pushed
the
graue/single-step
branch
from
0426944 to
2edd4b4
Compare
I've done this but it's kind of weird because if the instructions are long and you're toward the end, it zooms while the map isn't visible - except around the edges of the instructions. Oh well. |
I added position: relative to the main div of ItinerarySingleTransitStop to position the X in the top right corner. But this made that div the offsetParent, so useScrollToRef tried to scroll within it, instead of the actual scroll container (div.MapPlusOverlay_overlay). So I'm modifying useScrollToRef to iterate till it finds an actually scrollable container.
also, feedback about just using one viewingStepMarker variable
abhumbla
approved these changes
Dec 18, 2024
| InstructionSigns.FINISH | ||
| ) { | ||
| if (draft.viewingStep[0] + 1 === viewingRoute.legs.length) { | ||
| console.error('next step: would go past end'); |
There was a problem hiding this comment.
oh I left this on purpose so we can see if that's happening and correct it. If I wrote the code correctly, this case will never occur
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A usable view that allows you to step through each instruction step (for a bike leg) and each stop that a transit leg passes through.
Fixes #396