Desktop Layout [WIP] #398
Desktop Layout [WIP] #398
Conversation
| @@ -112,7 +112,7 @@ export default function DirectionsNullState(props: Props) { | |||
| values={{ | |||
| link: (chunks) => ( | |||
| <a | |||
| href="https://github.com/bikehopper/bikehopper-ui" | |||
| href="https://github.com/bikehopper/" | |||
There was a problem hiding this comment.
prefer to keep this pointed at ui for now since its readme has an overview of BikeHopper and BikeHopper's stack
I'm aware it's been argued that that isn't the correct place for an overview to live. however, currently it's the only public overview we have.
There was a problem hiding this comment.
i will make a more suitable public overview repo/page before merging this PR
| @@ -2,7 +2,8 @@ import { MapRefs } from '../hooks/useMapRefs'; | |||
| import { HtmlPortalNode, OutPortal } from 'react-reverse-portal'; | |||
|
|
|||
| type Props = { | |||
| sidebar?: JSX.Element; | |||
| header: JSX.Element; | |||
There was a problem hiding this comment.
Interesting, I elsewhere use React.ReactNode for these. Is there an argument for JSX.Element being more correct?
| @@ -0,0 +1,4 @@ | |||
| .ItineraryElevation__chart { | |||
There was a problem hiding this comment.
Per coding conventions please use Tailwind for new components
| @@ -0,0 +1,4 @@ | |||
| .Routes { | |||
| @@ -16,7 +16,7 @@ import useThrottledValue from './useThrottledValue'; | |||
| // first attaching to a node. | |||
|
|
|||
| export default function useResizeObserver( | |||
| callback: (dimensions: [number, number]) => void, | |||
| callback: (dimensions: [number, number] | null) => void, | |||
There was a problem hiding this comment.
Hmm good catch except that if I'm reading this right, is it actually [number, number] | [null, null]? (Why didn't it error?)
|
|
||
| const _isTouch = 'ontouchstart' in window; | ||
|
|
||
| type Props = { | ||
| onMapLoad: () => void; | ||
| onMapLoad?: () => void; | ||
| overlayRef: RefObject<HTMLElement>; |
There was a problem hiding this comment.
Why does this type not match the overlayRef type in src/hooks/useMapRefs? (This type is not nullable, and could be any HTML element, not just a div.)
current state
