diesel: Fix reexported error types #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error type passed into `managed_reexports!()` generates two type aliases: `PoolError<E>` and `HookError<E>`. `PoolError<M::Error>` is used e.g. by the `get()` fn of managed pools. But `M::Error` for the `Manager` in the `deadpool_diesel` crate is defined as `deadpool_diesel::Error`, not `diesel::ConnectionError`, which makes the reexport wrong or at least not as useful as it is meant to be. Interestingly, there is another `PoolError` type alias in the root module of `deadpool_diesel` with the correct generic type signature. `HookError<M::Error>` is used e.g. in the `post_create()` fn of the managed pool builders. As above, `M::Error` is defined as `deadpool_diesel::Error`, not `diesel::ConnectionError`. In this case there is no correct root module type alias either, which requires users to add a dependency on `deadpool` itself to get to the generic, non-type-alias variant of `HookError`.
Turbo87
force-pushed
the
diesel-errors
branch
from
297df9d to
c84fcc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error type passed into
managed_reexports!()generates two type aliases:PoolError<E>andHookError<E>.PoolError<M::Error>is used e.g. by theget()fn of managed pools. ButM::Errorfor theManagerin thedeadpool_dieselcrate is defined asdeadpool_diesel::Error, notdiesel::ConnectionError, which makes the reexport wrong or at least not as useful as it is meant to be. Interestingly, there is anotherPoolErrortype alias in the root module ofdeadpool_dieselwith the correct generic type signature.HookError<M::Error>is used e.g. in thepost_create()fn of the managed pool builders. As above,M::Erroris defined asdeadpool_diesel::Error, notdiesel::ConnectionError. In this case there is no correct root module type alias either, which requires users to add a dependency ondeadpoolitself to get to the generic, non-type-alias variant ofHookError.