Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

font show problem #261

Closed
qstesiro opened this issue Aug 14, 2021 · 1 comment · May be fixed by #338
Closed

font show problem #261

qstesiro opened this issue Aug 14, 2021 · 1 comment · May be fixed by #338

Comments

@qstesiro
Copy link

I change font in index.ts
"term = new Terminal({fontFamily: 'Monospace', fontSize: 13, lineHeight: 1, letterSpacing: 1});"

font show in browser, I have modified lineHeight to 1.5 problem can`t be solved

图片

Depending on the type of issue, please include the follwing information:

  • Node and NPM Version
    • node v10.19.0
    • npm 6.14.4
  • Server OS Version / Distribution / Processor Architecture
    • Ubuntu20
  • WebSSH2 release version
    • "version": "0.4.0",
      "release": "standard-version"
      "standard-version": "^9.3.0",
  • Browser Version and OS
    • firefox x64 v91.0
@azeliff3
Copy link

I too have seen this behavior on Firefox (x64 v93.0). It is not observed in Chrome/Edge. The issue seems to stem from xterm js. The version used by webssh2 ("^4.12.0") cuts off the bottom of characters (and most annoyingly, underscore characters).

If you switch over to xterm v"4.14.1", this behavior is fixed for underscores, but still cuts off lower portions of other characters.

fmeschbe added a commit to fmeschbe/webssh2 that referenced this issue Dec 12, 2021
@fmeschbe
Merge branch 'main' into fmeschbe/update-ssh2
fbf5e35 
* main:
  chore: remove warning from ts about IE stuff
  fix: deprecated term.setOption
  fix: update xterm.js fixes billchurch#261
  chore: update dev deps
  chore: update docs
  bump version 0.4.4
  chore: prep for 0.4.4 release
  chore: prep for 0.4.4 release
  docs: docker run billchurch/webssh2 for direct testing (billchurch#269)
  fix: dockerignore (billchurch#272)
  chore: bump version 0.4.3
  docs: update changelog
  docs: update docs for ssh.term and sshterm options (billchurch#265)
fmeschbe added a commit to fmeschbe/webssh2 that referenced this issue Dec 12, 2021
@fmeschbe
Merge branch 'main' into fmeschbe/fontSize-option
ca393f2 
* main:
  chore: remove warning from ts about IE stuff
  fix: deprecated term.setOption
  fix: update xterm.js fixes billchurch#261
  chore: update dev deps
  chore: update docs
  bump version 0.4.4
  chore: prep for 0.4.4 release
  chore: prep for 0.4.4 release
  docs: docker run billchurch/webssh2 for direct testing (billchurch#269)
  fix: dockerignore (billchurch#272)
  chore: bump version 0.4.3
  docs: update changelog
  docs: update docs for ssh.term and sshterm options (billchurch#265)
  build(deps): bump ssh2 from 0.8.9 to 1.4.0 in /app

# Conflicts:
#	app/client/public/webssh2.bundle.js
#	app/client/src/js/index.ts
fmeschbe added a commit to fmeschbe/webssh2 that referenced this issue Dec 12, 2021
@fmeschbe
Merge branch 'main' into fmeschbe/command
607ff92 
* main:
  chore: remove warning from ts about IE stuff
  fix: deprecated term.setOption
  fix: update xterm.js fixes billchurch#261
  chore: update dev deps
  chore: update docs
  bump version 0.4.4
  chore: prep for 0.4.4 release
  chore: prep for 0.4.4 release
  docs: docker run billchurch/webssh2 for direct testing (billchurch#269)
  fix: dockerignore (billchurch#272)
  chore: bump version 0.4.3
  docs: update changelog
  docs: update docs for ssh.term and sshterm options (billchurch#265)
fmeschbe added a commit to fmeschbe/webssh2 that referenced this issue Dec 12, 2021
@fmeschbe
Merge branch 'main' into fmeschbe/docker-config
60e3a29 
* main:
  chore: remove warning from ts about IE stuff
  fix: deprecated term.setOption
  fix: update xterm.js fixes billchurch#261
  chore: update dev deps
  chore: update docs
  bump version 0.4.4
  chore: prep for 0.4.4 release
  chore: prep for 0.4.4 release
  docs: docker run billchurch/webssh2 for direct testing (billchurch#269)
  fix: dockerignore (billchurch#272)
  chore: bump version 0.4.3
  docs: update changelog
  docs: update docs for ssh.term and sshterm options (billchurch#265)
  build(deps): bump ssh2 from 0.8.9 to 1.4.0 in /app
fmeschbe added a commit to fmeschbe/webssh2 that referenced this issue Dec 12, 2021
@fmeschbe
Merge branch 'fmeschbe/update-ssh2' into fmeschbe/wrk
5e3a1c5 
* fmeschbe/update-ssh2:
  chore: remove warning from ts about IE stuff
  fix: deprecated term.setOption
  fix: update xterm.js fixes billchurch#261
  chore: update dev deps
  chore: update docs
  bump version 0.4.4
  chore: prep for 0.4.4 release
  chore: prep for 0.4.4 release
  docs: docker run billchurch/webssh2 for direct testing (billchurch#269)
  fix: dockerignore (billchurch#272)
  chore: bump version 0.4.3
  docs: update changelog
  docs: update docs for ssh.term and sshterm options (billchurch#265)
hktalent pushed a commit to hktalent/webssh2 that referenced this issue Jun 3, 2022
@billchurch
fix: update xterm.js fixes billchurch#261
c72d2ce
hktalent pushed a commit to hktalent/webssh2 that referenced this issue Jun 3, 2022
@billchurch
fix: update xterm.js fixes billchurch#261
f248599
@billchurch billchurch mentioned this issue Aug 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(main): release webssh2 0.4.7-pre-5 billchurch/webssh2
2 participants
@qstesiro @azeliff3