Fix allowed subnets feature if hostname is not an IP #234
+179
−156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
holding this for a future release, but this looks good so far. |
billchurch
added a commit
that referenced
this pull request
May 17, 2021
|
Implemented in, 0.4.0-testing-1 thanks for the contribution. |
billchurch
added a commit
that referenced
this pull request
May 19, 2021
* feat: upgrade to socket.io 4.1.1 #242 * chore: lint ./app/client/src/js/index.js #242 * chore: eslint disable global Blob warning #242 * chore: lint ./app/index.js #242 * chore: lint ./app/server/app.js #242 * chore: setup eslint and airbnb rules disable standard #242 * Delete package-lock-old.json * chore: lint ./app/index.js #242 * feat: implement alpine docker image from #213 * chore: lint ./app/server/app.js still TODO for stop function #242 * chore: lint ./app/server/util.js #242 * chore: lint ./app/server/app.js reorg socket and safe shutdown * chore: grammar / spelling * chore: fix some misplaced next returns in some Express routes #242 * chore: lint ./app/server/socket.js #242 * chore: bump version in ./app/package.json #242 * docs: update docs for 0.4.0 #242 * chore: update package-lock.json * chore: install Prettier code linter #242 * chore: linting for Prettier #242 * chore: lint ./app/client/src/js/index.js #242 * chore: client linting #242 * Update package-lock.json * chore: repackage wbssh2 bundle for testing #242 * chore: convert ./app/client/src/js/index.js to typescript #242 * chore: remove html rendering from node * Update tsconfig.json * Update tsconfig.json * Delete index.js * Update ChangeLog.md * chore: config for development container #242 * Update BUILDING.md * feat: pull in #234 staged for 0.4.0 #242 * docs: update changelog * update package.json * chore: split config from app/server/app.js #242 * chore: version bump * chore: consistency * feat: overridebasic fixes #243 included for #242 * chore: remove serverlog code * docs: update changelog
hktalent
pushed a commit
to hktalent/webssh2
that referenced
this pull request
Jun 3, 2022
* feat: upgrade to socket.io 4.1.1 billchurch#242 * chore: lint ./app/client/src/js/index.js billchurch#242 * chore: eslint disable global Blob warning billchurch#242 * chore: lint ./app/index.js billchurch#242 * chore: lint ./app/server/app.js billchurch#242 * chore: setup eslint and airbnb rules disable standard billchurch#242 * Delete package-lock-old.json * chore: lint ./app/index.js billchurch#242 * feat: implement alpine docker image from billchurch#213 * chore: lint ./app/server/app.js still TODO for stop function billchurch#242 * chore: lint ./app/server/util.js billchurch#242 * chore: lint ./app/server/app.js reorg socket and safe shutdown * chore: grammar / spelling * chore: fix some misplaced next returns in some Express routes billchurch#242 * chore: lint ./app/server/socket.js billchurch#242 * chore: bump version in ./app/package.json billchurch#242 * docs: update docs for 0.4.0 billchurch#242 * chore: update package-lock.json * chore: install Prettier code linter billchurch#242 * chore: linting for Prettier billchurch#242 * chore: lint ./app/client/src/js/index.js billchurch#242 * chore: client linting billchurch#242 * Update package-lock.json * chore: repackage wbssh2 bundle for testing billchurch#242 * chore: convert ./app/client/src/js/index.js to typescript billchurch#242 * chore: remove html rendering from node * Update tsconfig.json * Update tsconfig.json * Delete index.js * Update ChangeLog.md * chore: config for development container billchurch#242 * Update BUILDING.md * feat: pull in billchurch#234 staged for 0.4.0 billchurch#242 * docs: update changelog * update package.json * chore: split config from app/server/app.js billchurch#242 * chore: version bump * chore: consistency * feat: overridebasic fixes billchurch#243 included for billchurch#242 * chore: remove serverlog code * docs: update changelog
hktalent
pushed a commit
to hktalent/webssh2
that referenced
this pull request
Jun 3, 2022
* feat: upgrade to socket.io 4.1.1 billchurch#242 * chore: lint ./app/client/src/js/index.js billchurch#242 * chore: eslint disable global Blob warning billchurch#242 * chore: lint ./app/index.js billchurch#242 * chore: lint ./app/server/app.js billchurch#242 * chore: setup eslint and airbnb rules disable standard billchurch#242 * Delete package-lock-old.json * chore: lint ./app/index.js billchurch#242 * feat: implement alpine docker image from billchurch#213 * chore: lint ./app/server/app.js still TODO for stop function billchurch#242 * chore: lint ./app/server/util.js billchurch#242 * chore: lint ./app/server/app.js reorg socket and safe shutdown * chore: grammar / spelling * chore: fix some misplaced next returns in some Express routes billchurch#242 * chore: lint ./app/server/socket.js billchurch#242 * chore: bump version in ./app/package.json billchurch#242 * docs: update docs for 0.4.0 billchurch#242 * chore: update package-lock.json * chore: install Prettier code linter billchurch#242 * chore: linting for Prettier billchurch#242 * chore: lint ./app/client/src/js/index.js billchurch#242 * chore: client linting billchurch#242 * Update package-lock.json * chore: repackage wbssh2 bundle for testing billchurch#242 * chore: convert ./app/client/src/js/index.js to typescript billchurch#242 * chore: remove html rendering from node * Update tsconfig.json * Update tsconfig.json * Delete index.js * Update ChangeLog.md * chore: config for development container billchurch#242 * Update BUILDING.md * feat: pull in billchurch#234 staged for 0.4.0 billchurch#242 * docs: update changelog * update package.json * chore: split config from app/server/app.js billchurch#242 * chore: version bump * chore: consistency * feat: overridebasic fixes billchurch#243 included for billchurch#242 * chore: remove serverlog code * docs: update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #199.
If a hostname is provided in the URL a DNS lookup is made to resolve the ip address.
I'm open to suggestions for improvement of the code.