Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing "Appointed Date" in current-prosecutors section #100

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

hicks2evan
Copy link
Contributor

Added a helper to format unix_ts as date, updated current_prosecutor template with updated date logic.

@hicks2evan
Copy link
Contributor Author

Hey @billimarie couple of things here to look at:

  1. I added moment as a dependency- could be done in vanilla js but is is a little bit more verbose, let me know :)
  2. I added a .js file just for the current-prosecutors template to hold the unix timestamp format helper, could see this being used elsewhere, but for now looks like it's enough for just this template

Please let me know if there is anything else I can look into here. Cool project!

@billimarie
Copy link
Owner

Hi @hicks2evan, thanks for tackling this. Everything looks good! Merging to master, updating #84, & creating a new issue (#101) for sanitizing database entries.

@billimarie billimarie merged commit 3954c87 into billimarie:hacktober2020 Oct 2, 2020
billimarie pushed a commit that referenced this pull request Oct 2, 2020
@billimarie billimarie added Hacktober Hacktoberfest hacktoberfest-accepted To count toward Hacktoberfest 2020 credit and removed Hacktober Hacktoberfest labels Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted To count toward Hacktoberfest 2020 credit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants