Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glad support and a few other things #105

Open
wants to merge 17 commits into
base: gwork
Choose a base branch
from
Open

Conversation

m00se-3
Copy link

@m00se-3 m00se-3 commented Oct 15, 2023

The following changes were made to integrate GWork with a side project of mine, hopefully that explains some of the seemingly random changes.

  • Added a USE_GLAD option to allow the user to bring in GLAD instead of GLEW for the OPENGL_CORE renderer. GLEW is still the default.
  • Added a USE_VCPKG option so that the library can use your VCPKG provided install of GLFW & GLM.
  • Bumped the minimum CMAKE version to 3.15, since CMAKE <= 3.5 is going to be unsupported soon.
  • Config.cmake checks for the host cpu to be 64-bit rather than checking for Win64. This is because GWork was setting GWK_TARGET_ARCH incorrectly on AMD64 systems.
  • Config.cmake checks for mingw rather than for Windows before linking to iconv. Checking for Win32 broke builds on Windows not using MinGW.
  • Updated the OpenGLCoreSample program to OpenGL 4.5 because the OpenGLCore renderer uses GL functions only supported in that version. Might consider changing the renderer to use equivalent functions compatible with more OpenGL versions.

In addition to the code reviews, feel free to provide feedback on the pull request overall. This is my first attempt at contributing to open source, so any advice is welcome.

@@ -95,7 +109,7 @@ int main()
canvas->SetBackgroundColor(Gwk::Color(150, 170, 170, 255));

// Create our unittest control (which is a Window with controls in it)
auto unit = new TestFrame(canvas);
auto unit = new Gwk::Test::TestFrame(canvas);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might have been my compiler settings causing this, but my compiler didn't like the namespaces not being there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant