Skip to content
This repository has been archived by the owner on Oct 30, 2023. It is now read-only.

binace-java-api doesn't pass through chosen newClientOrderId from the NewOrder object when placing a new order. #62

Closed
wiigor opened this issue Feb 2, 2018 · 0 comments

Comments

@wiigor
Copy link

wiigor commented Feb 2, 2018

@headers(BinanceApiConstants.ENDPOINT_SECURITY_TYPE_SIGNED_HEADER)
@post("/api/v3/order")
Call newOrder(@query("symbol") String symbol, @query("side") OrderSide side, @query("type") OrderType type,
@query("timeInForce") TimeInForce timeInForce, @query("quantity") String quantity, @query("price") String price,
@query("stopPrice") String stopPrice, @query("icebergQty") String icebergQty,
@query("recvWindow") Long recvWindow, @query("timestamp") Long timestamp);

The field clientOrderIdIs not passed through from a newOrder object to the binance API. This means we cannot set our own clientOrderId as specified by the APi documentation:

binance rest api doc:

newClientOrderId STRING NO A unique id for the order. Automatically generated if not sent.

Please add @query("newClientOrderId") String newClientOrderId

@wiigor wiigor changed the title binace-java-api doesn't pass through chosen clientOrderId when placing a new order. binace-java-api doesn't pass through chosen newClientOrderId from the NewOrder object when placing a new order. Feb 2, 2018
nilswx pushed a commit to nilswx/binance-java-api that referenced this issue Dec 14, 2018
Fixes binance-exchange#62: Add support for setting newClientOrderId for new orders
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant