Skip to content
This repository has been archived by the owner on Oct 30, 2023. It is now read-only.

Fix issue 72 ClassCastException on onAllMarketTickersEvent stream #117

Closed
wants to merge 1 commit into from
Closed

Fix issue 72 ClassCastException on onAllMarketTickersEvent stream #117

wants to merge 1 commit into from

Conversation

mjwchapman
Copy link

@mjwchapman mjwchapman commented Apr 23, 2018 •
edited
Loading

  1. Pass in a concrete type reference to the constructor so that it is available at runtime.
  2. Change 'Q A v q' fields from longs to doubles.
  3. Add best bid quantity and price fields.
  4. Update example to iterate over the event list thus exercising the full code path.

@mjwchapman
Fix issue 72 ClassCastException on onAllMarketTickersEvent stream
238eb2c 
1. Pass in a concrete type reference to the constructor so that it is
available at runtime.
2. Change 'Q A v q' fields from longs to doubles.
3. Add best bid quantity and price fields.
4. Update example to iterate over the event list thus exercising the
full code path.
@mjwchapman mjwchapman mentioned this pull request Apr 23, 2018
Closed
@big-andy-coates
Copy link

Duplicate of, or relating to, #163. In particular, in the other PR the moving away from doubles for financials, (which suffer from rounding errors), is a good thing!

@joaopsilva
Copy link
Member

Fixed in #163.

@joaopsilva joaopsilva closed this Sep 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjwchapman @big-andy-coates @joaopsilva