This repository has been archived by the owner on Oct 30, 2023. It is now read-only.
Support newOrderRespType and fix onFailure routing in BinanceApiCallbackAdapter #122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this library! I'm currently using it in my Scala project and I want to share some improvements.
Binance added
newOrderRespType
on their V3 API, allowing API clients to specify the desired response format by choosing betweenACK
/RESULT
/FULL
.FULL
makes Binance return full details on the newly created order, includingexecutedQty
andfills
, which in turn containprice
,qty
andcommission
. This enables you to calculate the (average) fill price for market orders. (fixes #105)binance-java-api
did not support this functionality yet. I also added error routing toBinanceApiCallbackAdapter
, which previously threw any exceptions rather than callingonFailure
of the wrappedBinanceApiCallback
. Now you can actually catch exceptions when using the async API.