Skip to content
This repository has been archived by the owner on Oct 30, 2023. It is now read-only.

Withdrawal Improvements #16

Closed
wants to merge 1 commit into from

Conversation

crypto-noob
Copy link

Added WithdrawResult support
Added support for address tags
Fixed DepositHistory get if msg present

Fixed DepositHistory get if msg present
@mcourteaux
Copy link

  1. I think they won't like the wildcard import (import foo.bar.*;)
  2. I think they will say that every other "result" class is actually called "Response" (eg: NewOrderReponse), instead of "Result".

@joaopsilva
Copy link
Member

Thank you @crypto-noob , could you please implement the changes mentioned by @mcourteaux ? Thanks!

Copy link
Member

@joaopsilva joaopsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #126.

@joaopsilva joaopsilva closed this Sep 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants