This repository has been archived by the owner on Oct 30, 2023. It is now read-only.
fix-objectmapper #30
Merged
fix-objectmapper #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had a quick look since I wasn't sure if ObjectMapper was thread-safe, but it is. In that case, your solution works well. Thank you! |
nilswx
pushed a commit
to nilswx/binance-java-api
that referenced
this pull request
Dec 14, 2018
Avoid creating multiple ObjectMapper objects for deserialization.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #29
Normally, you would only use a single Jackson ObjectMapper per the entire app, injected via DI or any other means.
However, after looking at the current code, there's no way to delegate ObjectMapper construction in UserDataUpdateEventDeserializer.
Hence for this edge case, it is created lazily on first access instead of recreating it each time on deserialization.