This repository has been archived by the owner on Oct 30, 2023. It is now read-only.
Expose WebSockets for graceful closing #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…disconnects after 24 hours.
|
Agreed. The ability to shutdown web sockets is also covered by #49, with more besides. I chose not to expose the full web socket, as I felt that broke encapsulation, so instead I just return a |
|
Not using this anymore. Using #49 instead. |
skrser
added a commit
to skrser/binance-java-api
that referenced
this pull request
Apr 26, 2021
skrser
added a commit
to skrser/binance-java-api
that referenced
this pull request
Apr 26, 2021
…implify and reorder
skrser
added a commit
to skrser/binance-java-api
that referenced
this pull request
Jul 22, 2021
skrser
added a commit
to skrser/binance-java-api
that referenced
this pull request
Jul 22, 2021
…implify and reorder
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binance disconnects after 24 hours of websocket streaming. To prevent this, we should be able to open a new websocket, and switch over to the new one, before the 24h mark. After the live switchover, we need to be able to close the original one. Exposing the okhttp.WebSocket allows us to perform:
.close().