This repository has been archived by the owner on Oct 30, 2023. It is now read-only.
Allow up to 100 connections to binance. #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @mcourteaux . |
nilswx
pushed a commit
to nilswx/binance-java-api
that referenced
this pull request
Dec 14, 2018
Allow up to 100 connections to Binance's WebSocket Client.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OkHTTP3 limits the amount of connections to the same host to 5. This means you cannot open more than 5 steams of events. Truly undesirable within this context. I increased the amount to 100, for ease of use.
Having it on the default of 5, just causes you to be able to open websockets, but they wont provide you with any data. We tested this, and this fix resolves the issue.