This repository has been archived by the owner on Oct 30, 2023. It is now read-only.
forked from joaopsilva/binance-java-api
-
Notifications
You must be signed in to change notification settings - Fork 622
Added AllMarketTickers channel #56
Merged
joaopsilva
merged 3 commits into
binance-exchange:master
from
tonyskulk:all-market-tickers
Jan 29, 2018
Merged
Added AllMarketTickers channel #56
joaopsilva
merged 3 commits into
binance-exchange:master
from
tonyskulk:all-market-tickers
Jan 29, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Very nice. |
joaopsilva
reviewed
Jan 27, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thanks @tonyskulk . Could you please add an example of using this to the test
directory?
} | ||
|
||
@Override | ||
public String toString() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please replace this to use the ToStringBuilder
that is used in other transfer objects? Thanks.
Switched to ToStringBuilder and made a very simple self-explaining example |
Hi @tonyskulk , could you please have a look at the issue reported in #72? Thanks. |
Would be useful to update the example so that it highlights the problematic code path, e.g.
|
nilswx
pushed a commit
to nilswx/binance-java-api
that referenced
this pull request
Dec 14, 2018
Added AllMarketTickers WebSockets channel.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.