Skip to content
This repository has been archived by the owner on Oct 30, 2023. It is now read-only.

Added AllMarketTickers channel #56

Merged
merged 3 commits into from
Jan 29, 2018

Conversation

tonyskulk
Copy link

No description provided.

@xezon
Copy link

xezon commented Jan 27, 2018

Very nice.

Copy link
Member

@joaopsilva joaopsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks @tonyskulk . Could you please add an example of using this to the test directory?

}

@Override
public String toString() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please replace this to use the ToStringBuilder that is used in other transfer objects? Thanks.

@tonyskulk
Copy link
Author

Switched to ToStringBuilder and made a very simple self-explaining example

@joaopsilva joaopsilva merged commit e3df9d7 into binance-exchange:master Jan 29, 2018
@tonyskulk tonyskulk deleted the all-market-tickers branch January 30, 2018 12:28
@joaopsilva
Copy link
Member

Hi @tonyskulk , could you please have a look at the issue reported in #72? Thanks.

@mjwchapman
Copy link

mjwchapman commented Apr 22, 2018

Would be useful to update the example so that it highlights the problematic code path, e.g.

        webSocketClient.onAllMarketTickersEvent(eventList -> {
            try {
                for (AllMarketTickersEvent event : eventList) {
                    System.out.println(event);
                }
            } catch (Exception e) {
                e.printStackTrace();
            }
        });

nilswx pushed a commit to nilswx/binance-java-api that referenced this pull request Dec 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants