This repository has been archived by the owner on Oct 30, 2023. It is now read-only.
Added ability to query 24hr ticker price change statistics for all sy… #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mbols and to query latest price for single symbol Signed-off-by: Sai Chaitanya Chitneedi <nomail_forme@yahoo.in>
joaopsilva
suggested changes
Feb 4, 2018
There was a problem hiding this comment.
@nomailforme thank you for this, it looks good, could you please just apply the changes I mentioned in the code review before I merge it into master?
| * @param symbol ticker symbol (e.g. ETHBTC) | ||
| * @param callback the callback that handles the response | ||
| */ | ||
| void getSymbolPrice(String symbol , BinanceApiCallback<TickerPrice> callback); |
|
|
||
| @Override | ||
| public void getAll24HrPriceStatistics(BinanceApiCallback<List<TickerStatistics>> callback) { | ||
| binanceApiService.getAll24HrPriceStatistics().enqueue(new BinanceApiCallbackAdapter<>(callback)); |
There was a problem hiding this comment.
Please use 2 whitespaces for indentation.
There was a problem hiding this comment.
Done, But I would have much preferred tab for indentation. Its more standard In my opinion :)
|
|
||
| @GET("/api/v1/ticker/allPrices") | ||
| Call<List<TickerPrice>> getLatestPrices(); | ||
|
|
||
| @GET("/api/v3/ticker/price") | ||
| Call<TickerPrice> getSymbolPrice(@Query("symbol") String symbol); |
There was a problem hiding this comment.
For consistency, can you please call this getLatestPrice?
|
Made changes. Feel free to merge :) |
joaopsilva
approved these changes
Feb 6, 2018
|
Thank you @nomailforme . |
nilswx
pushed a commit
to nilswx/binance-java-api
that referenced
this pull request
Dec 14, 2018
Added ability to query 24hr ticker price change statistics for all symbols.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to query 24hr ticker price change statistics for all symbols and to query latest price for single symbol
Signed-off-by: Sai Chaitanya Chitneedi