feat(expo-notifications): handle expo-notifications #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MateuszRostkowski
approved these changes
Nov 24, 2022
src/navigation/RootNavigator.tsx
Outdated
Comment on lines
23
to
39
| const { notification, setNotification } = useNotificationContext() | ||
|
|
||
| useEffect(() => { | ||
| const initNotifications = async () => { | ||
| await registerForPushNotificationsAsync() | ||
| } | ||
| initNotifications() | ||
| }, []) | ||
|
|
||
| useEffect(() => { | ||
| if (notification) { | ||
| Alert.alert('Notification', JSON.stringify(notification), [ | ||
| { text: 'Cancel', onPress: () => setNotification(undefined), style: 'cancel' }, | ||
| { text: 'Ok', onPress: () => setNotification(undefined) }, | ||
| ]) | ||
| } | ||
| }, [notification, setNotification]) |
There was a problem hiding this comment.
Maybe move it to seperate file, for example useNotificationsSetup, it will be easier to maintain it in the future
src/navigation/RootNavigator.tsx
Outdated
|
|
||
| useEffect(() => { | ||
| if (notification) { | ||
| Alert.alert('Notification', JSON.stringify(notification), [ |
There was a problem hiding this comment.
Maybe instead of displaying it in alert you can use react-native-notificated package that we have implemented.
It's just a proposition, maybe it will look better
MateuszRostkowski
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr introduces expo-notifications.
Type of change
How Has This Been Tested?
**For both tests copy Expo push token from application settings and paste it to: **
in Expo Push Notification Tool - https://expo.dev/notifications
Test A
Send a Notification.Notification from foregroundon an Alert.Test B
Send a Notification.Notification from background.Screenshot(s)
Foreground
Background
Test Configuration:
OS: macOS 12.6
CPU: (8) arm64 Apple M1
Memory: 194.66 MB / 16.00 GB
Shell: 5.8.1 - /bin/zsh
Checklist: