Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added alert working on web #8

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Conversation

zagoorland
Copy link

@zagoorland zagoorland commented Nov 4, 2022

Description

Added alert working on web

Fixes # (issue)

usePreventGoBack wasn't working on web since it used RN Alert only.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Screenshot(s)

Please attach some screenshot or a movie if provided changes affects UI.

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • Add correct label to your pull request
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Comment on lines +11 to +21
const alertPolyfill = (title: string, description: string, options: any) => {
const result = window.confirm([title, description].filter(Boolean).join('\n'))

if (result) {
const confirmOption = options.find(({ style }: { style: string }) => style !== 'cancel')
confirmOption && confirmOption.onPress()
} else {
const cancelOption = options.find(({ style }: { style: string }) => style === 'cancel')
cancelOption && cancelOption.onPress()
}
}
Copy link
Collaborator

@MateuszRostkowski MateuszRostkowski Nov 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move it utils, you can do something like this:

import { Alert as RNAlert, Platform } from 'react-native'


const alertPolyfill = (title: string, description: string, options: any) => {
   const result = window.confirm([title, description].filter(Boolean).join('\n'))

   if (result) {
      const confirmOption = options.find(({ style }: { style: string }) => style !== 'cancel')
      confirmOption && confirmOption.onPress()
   } else {
      const cancelOption = options.find(({ style }: { style: string }) => style === 'cancel')
      cancelOption && cancelOption.onPress()
   }
}
  
export  const Alert = {
     ...RNAlert,
     alert: Platform.OS === 'web' ? alertPolyfill : RNAlert.alert
 }

Thanks to that, we can use this alert in all components

@MateuszRostkowski MateuszRostkowski merged commit b6d57d2 into main Nov 18, 2022
@MateuszRostkowski MateuszRostkowski deleted the fix/prevent-go-back-web branch January 20, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants