Skip to content
This repository was archived by the owner on Feb 22, 2024. It is now read-only.

fix: move Derived to the correct position based on requirements #7287

Merged
merged 8 commits into from
Jan 30, 2023
Merged

fix: move Derived to the correct position based on requirements #7287

merged 8 commits into from
Jan 30, 2023

Conversation

@aizad-deriv
Copy link
Contributor

@aizad-deriv aizad-deriv commented Nov 9, 2022

No description provided.

@vercel
Copy link

vercel bot commented Nov 9, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
binary-static ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 30, 2023 at 5:44AM (UTC)

@github-actions
Copy link

github-actions bot commented Nov 9, 2022 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/binary-static/pull/7287](https://github.com/binary-com/binary-static/pull/7287)
- **URLs**:
    - **w/ App ID + Server**: https://binary-static-git-fork-aizad-deriv-aizad-80390derived-mo-3adb83.binary.sx/en/logged_inws.html?qa_server=frontend.binaryws.com&app_id=27922
    - **Original**: https://binary-static-git-fork-aizad-deriv-aizad-80390derived-mo-3adb83.binary.sx/en/logged_inws.html
- **App ID**: `27922`

ameerul-deriv
ameerul-deriv reviewed Nov 9, 2022
View reviewed changes
suisin-deriv
suisin-deriv reviewed Nov 9, 2022
View reviewed changes
src/sass/app/components/market.scss Outdated
font-weight: 700;
flex: 1 0 auto;
color: $COLOR_BLUE;
transition: none;
Copy link
Contributor

@suisin-deriv suisin-deriv Nov 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove this as default value for transition is none?

Copy link
Contributor Author

@aizad-deriv aizad-deriv Nov 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡 can

ameerul-deriv
ameerul-deriv previously approved these changes Nov 9, 2022
View reviewed changes
suisin-deriv
suisin-deriv previously approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@suisin-deriv suisin-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ameerul-deriv
ameerul-deriv reviewed Nov 14, 2022
View reviewed changes
src/sass/app/components/market.scss Outdated
padding: 10px 0;
font-weight: 400;
flex: 1 0 auto;
color: $COLOR_BLUE;
Copy link

@ameerul-deriv ameerul-deriv Nov 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we add a mixin for .subgroup-name and .label? the css is basically the same except for the font-weight

ameerul-deriv
ameerul-deriv reviewed Nov 14, 2022
View reviewed changes
src/sass/app/components/market.scss Outdated
@media (max-width: 767px) {
top: 123px;
width: calc(100% - 16px);
}
Copy link

@ameerul-deriv ameerul-deriv Nov 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here for .sticky and the one under .label

ameerul-deriv
ameerul-deriv reviewed Nov 14, 2022
View reviewed changes
src/sass/app/components/market.scss Outdated
padding: 10px 0 0;
flex: 1 0 auto;
font-weight: 300;
color: $COLOR_ORANGE;
Copy link

@ameerul-deriv ameerul-deriv Nov 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could also relate to the mixin I mentioned for .subgroup-name since they're quite similar

ameerul-deriv
ameerul-deriv previously approved these changes Nov 14, 2022
View reviewed changes
Copy link

@ameerul-deriv ameerul-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jim-deriv
jim-deriv previously approved these changes Nov 14, 2022
View reviewed changes
akmal-deriv
akmal-deriv previously approved these changes Nov 21, 2022
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.0% 1.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.0% 1.0% Duplication

@matin-deriv matin-deriv merged commit 596fe3a into binary-com:master Jan 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

4 more reviewers

@akmal-deriv akmal-deriv akmal-deriv left review comments

@suisin-deriv suisin-deriv suisin-deriv left review comments

@ameerul-deriv ameerul-deriv ameerul-deriv left review comments

@jim-deriv jim-deriv jim-deriv left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@aizad-deriv @akmal-deriv @suisin-deriv @ameerul-deriv @jim-deriv @matin-deriv