Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check against rails 7 0 rc1 #745

Merged
merged 8 commits into from
Dec 21, 2021

Conversation

danlaffan
Copy link
Contributor

This pull request has two changes:

  1. Change the Rails 7 version to call 7.0.0.rc1.
  2. Fix the underlying code to avoid a default_timezone depreciation warning.

All comments / questions welcome.

@danlaffan
Copy link
Contributor Author

Hi @jaredbeck - whenever you get a minute, please have a look and let me know what you think.

Cheers, Dan

gemfiles/rails_7.0.rb Outdated Show resolved Hide resolved
gemfiles/rails_7.0.rb Outdated Show resolved Hide resolved
lib/authlogic/session/base.rb Outdated Show resolved Hide resolved
@danlaffan
Copy link
Contributor Author

Hi @jaredbeck and @morgoth - Sorry for the radio silence. I was stuck on an important bug in my Turbo project, and got it sorted last night after a random piece of inspiration.

I will update this today and take on board the feedback you have both generously provided.

Cheers, Dan.

@danlaffan
Copy link
Contributor Author

@jaredbeck @morgoth I have just posted some commits to do the following:

  • Update the gemfile to Rails 7.0.0.
  • Fix the default_timezone deprecation as suggested.
  • Fix another deprecation .to_s(:db) -> .to_formatted_s(:db)

All tests pass on my local machine. Let's see if Github agrees.

@danlaffan
Copy link
Contributor Author

Looks like the checks have passed. @jaredbeck ready for review.

Copy link
Collaborator

@jaredbeck jaredbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting close! Thanks Dan.

lib/authlogic/session/base.rb Outdated Show resolved Hide resolved
@danlaffan
Copy link
Contributor Author

Agreed @jaredbeck .

@danlaffan
Copy link
Contributor Author

@jaredbeck - change pushed and tests passed.

@jaredbeck jaredbeck merged commit ef95d13 into binarylogic:master Dec 21, 2021
@danlaffan
Copy link
Contributor Author

Thanks @jaredbeck !

@morgoth I think we're all set here.

@jaredbeck
Copy link
Collaborator

Released in 6.4.2. Thanks y'all

@dima4p
Copy link

dima4p commented Sep 27, 2024

Then a new version of the gem is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants