-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check against rails 7 0 rc1 #745
Check against rails 7 0 rc1 #745
Conversation
Hi @jaredbeck - whenever you get a minute, please have a look and let me know what you think. Cheers, Dan |
Hi @jaredbeck and @morgoth - Sorry for the radio silence. I was stuck on an important bug in my Turbo project, and got it sorted last night after a random piece of inspiration. I will update this today and take on board the feedback you have both generously provided. Cheers, Dan. |
@jaredbeck @morgoth I have just posted some commits to do the following:
All tests pass on my local machine. Let's see if Github agrees. |
Looks like the checks have passed. @jaredbeck ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting close! Thanks Dan.
Agreed @jaredbeck . |
@jaredbeck - change pushed and tests passed. |
Thanks @jaredbeck ! @morgoth I think we're all set here. |
Released in 6.4.2. Thanks y'all |
Then a new version of the gem is required. |
This pull request has two changes:
default_timezone
depreciation warning.All comments / questions welcome.