Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

javax.servlet-api需要更换为jakarta.servlet-api #3160

Closed
witt-bit opened this issue Nov 7, 2023 · 1 comment · Fixed by #3181
Closed

javax.servlet-api需要更换为jakarta.servlet-api #3160

witt-bit opened this issue Nov 7, 2023 · 1 comment · Fixed by #3181

Comments

@witt-bit
Copy link

witt-bit commented Nov 7, 2023

目前如果只需要weixin-java-pay的小部分功能，项目仍然会引入javax.servlet-api依赖，导致项目中的@ConditionalOnClass在适配新老项目时出现问题

模块版本情况

  • WxJava 模块名: weixin-java-pay
  • WxJava 版本号: 4.5.6.B

建议:
1.尽快升级为jakarta
2.将servlet-api依赖不可传递，改为optional
@binarywang
Copy link
Owner

欢迎直接提供可靠的优化代码并提交PR

0katekate0 pushed a commit to 0katekate0/WxJava that referenced this issue Dec 8, 2023
【微信支付】 binarywang#3160 修改servlet依赖不可传递，编译和测试时使用
e1dd962
@0katekate0 0katekate0 mentioned this issue Dec 8, 2023
Merged
@binarywang binarywang linked a pull request Dec 9, 2023 that will close this issue
【微信支付】 #3160 修改servlet依赖不可传递，编译和测试时使用 #3181
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@binarywang @witt-bit