Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overflow error when deserializing invalid Duration #465

Merged
merged 2 commits into from
Jan 8, 2022

Conversation

5225225
Copy link
Contributor

@5225225 5225225 commented Jan 8, 2022

No description provided.

tests/basic_types.rs Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2022

Codecov Report

Merging #465 (bf13f2f) into trunk (4fea079) will increase coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk     #465      +/-   ##
==========================================
+ Coverage   66.64%   66.82%   +0.18%     
==========================================
  Files          35       35              
  Lines        2647     2662      +15     
==========================================
+ Hits         1764     1779      +15     
  Misses        883      883              
Impacted Files Coverage Δ
src/error.rs 0.00% <ø> (ø)
src/de/impls.rs 79.22% <100.00%> (+0.14%) ⬆️
tests/basic_types.rs 99.19% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fea079...bf13f2f. Read the comment docs.

@VictorKoenders VictorKoenders merged commit a14ea97 into bincode-org:trunk Jan 8, 2022
@VictorKoenders
Copy link
Contributor

Thanks!

@5225225 5225225 deleted the duration-fix branch January 8, 2022 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants