Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GenConst: moved into gen_const.rs #55

Merged
merged 3 commits into from
May 16, 2023
Merged

GenConst: moved into gen_const.rs #55

merged 3 commits into from
May 16, 2023

Conversation

wbcat
Copy link
Contributor

@wbcat wbcat commented Apr 24, 2023

closes #54

  • make_pub added
  • Impl.generate_const added

new mod gen_const.rs, contains GenConst + impl, formerly residingin in impl_for.rs

- make_pub added
- Impl.generate_const added
@codecov
Copy link

codecov bot commented May 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.13 🎉

Comparison is base (ff02e57) 48.58% compared to head (e35dafb) 49.72%.

❗ Current head e35dafb differs from pull request most recent head 90d64e8. Consider uploading reports for the commit 90d64e8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk      #55      +/-   ##
==========================================
+ Coverage   48.58%   49.72%   +1.13%     
==========================================
  Files          19       20       +1     
  Lines        2019     1965      -54     
==========================================
- Hits          981      977       -4     
+ Misses       1038      988      -50     
Impacted Files Coverage Δ
src/generate/gen_const.rs 0.00% <0.00%> (ø)
src/generate/impl.rs 0.00% <0.00%> (ø)
src/generate/impl_for.rs 46.25% <0.00%> (+5.25%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@VictorKoenders
Copy link
Contributor

LGTM, can you rebase or merge the latest trunk?

@wbcat
Copy link
Contributor Author

wbcat commented May 16, 2023

Merged the latest trunk.
Anything else?

@VictorKoenders
Copy link
Contributor

Looks good to me! Sorry this took a while to merge, life has been busy

@VictorKoenders VictorKoenders enabled auto-merge (squash) May 16, 2023 11:49
@VictorKoenders VictorKoenders merged commit 50e81e3 into bincode-org:trunk May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to generated associated pub constants for impl?
2 participants