add sdl2_image/2.0.5 and sdl2_mixer/2.0.4 #1317

Croydon · 2020-12-13T13:26:08Z

Ported from

https://github.com/bincrafters/conan-sdl2_image

https://github.com/bincrafters/conan-sdl2_mixer

Croydon · 2020-12-13T14:26:19Z

Hm. I do except a few build errors, but apparently it can't find SDL2 packages for any configuration.

Do we need to rebuild SDL2?

Croydon · 2020-12-13T18:46:16Z

conans.errors.ConanException: Missing prebuilt package for 'libmikmod/3.3.11.1@bincrafters/stable', 'libmpg123/1.25.13@bincrafters/stable'

I don't understand why we suddenly lack many packages 🤔

ericLemanissier · 2020-12-14T08:23:12Z

it could be a consequence of conan-io/conan-center-index@8fa0843

Would it be possible to make a PR per package in the future, because here it's hard to keep track of which CI job failed

Croydon · 2020-12-14T08:43:08Z

Would it be possible to make a PR per package in the future, because here it's hard to keep track of which CI job failed

Sure, I just wanted to test once with a real example that it works to update several recipes at once. This will be handy when it comes to mass convention updates

Croydon · 2020-12-14T15:04:18Z

Still the same error

it could be a consequence of conan-io/conan-center-index@8fa0843

The PR does not seem to have changed the default dependencies or the dependency versions and both libmikmod and libmpg123 are now rebuild

ericLemanissier · 2020-12-14T16:13:50Z

I can see missing binaries for SDL2. the Clang5 and GCC7 build of libmikmod failed on https://github.com/bincrafters/community/actions/runs/420980056

Still the same error

it could be a consequence of conan-io/conan-center-index@8fa0843

The PR does not seem to have changed the default dependencies or the dependency versions and both libmikmod and libmpg123 are now rebuild

yes, it's the option modification which invalidated hashes

Croydon · 2020-12-14T17:06:49Z

the Clang5 and GCC7 build of libmikmod failed on https://github.com/bincrafters/community/actions/runs/420980056

I restarted. Now only GCC 9 and Clang 9 are missing, due to the container image issues

sdl2_mixer fails on all Linux configurations

ericLemanissier · 2020-12-14T17:10:01Z

Maybe because the CI env var is not set ? https://github.com/bincrafters/community/pull/1317/files#diff-0f3725eeb4412e1c0465229cf69fd6e23ccee95e2e0524ddd92695c86a63a779R11

Croydon · 2020-12-15T05:24:08Z

I believe I had looked at the logs from the previous commit again and came to the conclusion that it is still the same error.

I think you are right. But probably it is better to rewrite the test_package in a way that works for all cases, being it local, Bincrafters' CI and C3I.

Croydon · 2020-12-15T06:45:16Z

Maybe the missing packages are caused by our regular connection timeouts to Bintray, and we didn't notice this before so strongly because we used outdated packages (which we are now getting deleted again).

ericLemanissier · 2020-12-15T06:49:17Z

Yes, few minutes ago I manually restarted the SDL2 merge commit build cab627a because the clang 7 build originally failed with a timeout. it should be ok now so I just restarted this PR's builds

Croydon · 2020-12-15T07:00:30Z

fluidsynth packages are missing too. I just started a new build there too

ericLemanissier · 2020-12-15T08:13:44Z

So now we only have the MSVC link error of sdl2_image test recipe SDL2.lib(SDL_string.obj) : error LNK2005: memset already defined in vcruntime.lib(VCRUNTIME140.dll) [D:\a\1\s\recipes\sdl2_image\all\test_package\build\00e278e71bbf6eaa9abab912b397d40627769cc4\test_package.vcxproj] , I'm not sure what can be done

Croydon · 2020-12-15T09:23:41Z

Neither do I. This error is around for a long time and I believe that was even discussed upstream once. Let me look if I can find that again

Croydon · 2020-12-15T09:28:15Z

We are adding a patch, defining memset to SDL2

Upstream seems to have fixed that in the meantime, there are several commits regarding memset https://github.com/SDL-mirror/SDL/commits/master/src/stdlib/SDL_string.c

I'm not sure yet which parts should be backported in a patch

Croydon · 2020-12-15T10:03:43Z

https://developercommunity.visualstudio.com/content/problem/711317/unexpected-implicit-memset-in-release-optimized-bu.html
https://stackoverflow.com/questions/58288692/cant-build-solution-in-release-mode-for-sdl-library-on-vs-2019

memset is defined in the vcruntime

SDL does not want to link against vcruntime by default. The preprocessor flags HAVE_MEMSET do fail for some reason.

Two ways to solve this:

define memset via patch ourselves (that is what we currently do)
link SDL against vcruntime

Our current way works for SDL itself. But SDL_image links against vcruntime. Hence we have two definitions of memset and it fails.

This reverts commit fd0539c.

in the next versions right now we use custom CMake files

SpaceIm · 2021-02-06T09:46:00Z

recipes/sdl2_image/2.0.5/conanfile.py

+        self._cmake.definitions["TIF_DYNAMIC"] = self.options["libtiff"].shared if self.options.tif else False
+        self._cmake.definitions["JPG_DYNAMIC"] = self.options["libjpeg"].shared if self.options.jpg else False
+        self._cmake.definitions["PNG_DYNAMIC"] = self.options["libpng"].shared if self.options.png else False
+        self._cmake.definitions["WEBP_DYNAMIC"] = self.options["libwebp"].shared if self.options.webp else False
+        self._cmake.definitions["SDL2_DYNAMIC"] = self.options["sdl2"].shared


It's not because libtiff is shared that consumer wants dynamic load. In upstream configure.in, there is a specific option (true by default) for each dependency for which sdl2_image supports dynamic load (libtiff, libjpeg, libpng and libwebp).
So, you can link to static, to shared, or dynamically load shared.

Moreover, there is no dynamic load of sdl2 in sdl2_image, it's always linked.

Thanks for the catch. We are currently using a custom CMake file for sdl2_image, only the next version will have official CMake support.

I will rename the SDL2_DYNAMIC option name as it only seems to make a switch between static and shared linking. Not entirely sure how to proceed with the rest.

Is dynamic loading just working, despite our custom CMake file?
If yes, we don't necessarily need special handling I guess.
If not, it doesn't work right now

From what I see in this custom CMake file, nothing is done with these definitions (except SDL2_DYNAMIC, but it's a different purpose and this CMake option could be avoided), so well let's say that the "dynamic" options in upstream configure.in is not supported for the moment in this recipe.

Is dynamic loading just working, despite our custom CMake file?

It can't work with this custom CMakeLists, there is an explicit branching with macros for dynamic load handling at runtime:
https://github.com/SDL-mirror/SDL_image/blob/b4f28c1fc9ab2f91ae594fc3e86622c5c13ffbbb/configure.in#L358-L364
https://github.com/SDL-mirror/SDL_image/blob/f4f5caf21d6f18de85baee945348f56697d1813a/IMG_jpg.c#L70-L77

recipes/sdl2_mixer/2.0.4/conanfile.py

Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>

ericLemanissier · 2021-07-20T17:11:47Z

So we are now missing binaries for fluidsynth => #1404
and for sdl => #1405

Croydon · 2021-07-20T17:12:59Z

Damn. I need to update the CI files. But I'm really confused why this error did not happen sooner

recipes/sdl2_mixer/2.0.4/conanfile.py

ericLemanissier · 2021-07-20T18:29:12Z

Which files are you talking about?

Croydon · 2021-07-21T07:39:22Z

I was talking about the GitHub Workflow CI file. The push CI jobs fail, because this branch is too old and does not have the newest files, which was confusing me for a moment. Let's rebase this branch.

Edit: Or lets just ignore those CI jobs for the moment :D

Croydon · 2021-07-21T08:00:43Z

While there are still a lot of small and huge things to improve, I would be fine with merging this state finally

Croydon requested a review from ericLemanissier December 13, 2020 13:27

Croydon force-pushed the sdls branch from 2fbd9b9 to aed25fc Compare December 13, 2020 14:20

Croydon force-pushed the sdls branch from aec4ef5 to 57c5f24 Compare January 1, 2021 19:29

Croydon added 11 commits January 1, 2021 20:31

add sdl2_mixer/2.0.4

f2d0a03

add sdl2_image/2.0.5

d8ae643

sdl2_image: cache CMake

cf1077b

sdl2_mixer: nit-picking (triggering CI)

d787333

sdl2_mixer: nit-picking formatting

bc36a9b

sdl2_mixer: update test_package

2cd0b85

sdl2_mixer: add more topics

52e3422

sdl2: test if it compiles without patch

f1bbe91

Revert "sdl2: test if it compiles without patch"

f95dffe

This reverts commit fd0539c.

sdl2_image: use find_package in test_package

a4a3a0f

sdl2_image: use find_package and targets for linking deps

53a6f48

Croydon and others added 5 commits January 1, 2021 20:33

update urls

b9272d7

migrate libmikmod to CCI

90e1d73

update to sdl 2.0.14

0aec28f

sdl2_image: fix license packaging

91a9536

sdl2_image: simplify imageio handling

a200b88

Croydon force-pushed the sdls branch from 57c5f24 to a200b88 Compare January 1, 2021 19:34

Croydon added 2 commits January 1, 2021 21:52

move to versioned folders to prepare for upstream CMake files

2da3cf3

in the next versions right now we use custom CMake files

Update libmpg123

2d8f407

SpaceIm reviewed Feb 6, 2021

View reviewed changes

Croydon mentioned this pull request Apr 14, 2021

Migration efforts of recipes in single recipe repositories #1380

Open

Croydon closed this Jul 8, 2021

Croydon reopened this Jul 8, 2021

This comment has been minimized.

Sign in to view

ericLemanissier closed this Jul 18, 2021

ericLemanissier reopened this Jul 18, 2021

ericLemanissier reviewed Jul 20, 2021

View reviewed changes

recipes/sdl2_mixer/2.0.4/conanfile.py Outdated Show resolved Hide resolved

Migrate tinymidi to CCI version

e8cd753

Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>

ericLemanissier reviewed Jul 20, 2021

View reviewed changes

recipes/sdl2_mixer/2.0.4/conanfile.py Outdated Show resolved Hide resolved

ericLemanissier and others added 2 commits July 21, 2021 01:11

Update recipes/sdl2_mixer/2.0.4/conanfile.py

b1541f7

add DLL_EXPORT for shared libs

45369ff

ericLemanissier force-pushed the sdls branch from 935e278 to 45369ff Compare July 21, 2021 07:34

Rename confusing CMake definition

8cd9757

ericLemanissier approved these changes Jul 21, 2021

View reviewed changes

CroydonBot merged commit 72ff676 into main Jul 21, 2021

CroydonBot deleted the sdls branch July 21, 2021 09:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add sdl2_image/2.0.5 and sdl2_mixer/2.0.4 #1317

add sdl2_image/2.0.5 and sdl2_mixer/2.0.4 #1317

Croydon commented Dec 13, 2020 •

edited

Loading

Croydon commented Dec 13, 2020

Croydon commented Dec 13, 2020

ericLemanissier commented Dec 14, 2020 •

edited

Loading

Croydon commented Dec 14, 2020

Croydon commented Dec 14, 2020

ericLemanissier commented Dec 14, 2020 •

edited

Loading

Croydon commented Dec 14, 2020

ericLemanissier commented Dec 14, 2020

Croydon commented Dec 15, 2020

Croydon commented Dec 15, 2020

ericLemanissier commented Dec 15, 2020

Croydon commented Dec 15, 2020

ericLemanissier commented Dec 15, 2020

Croydon commented Dec 15, 2020

Croydon commented Dec 15, 2020

Croydon commented Dec 15, 2020

SpaceIm Feb 6, 2021 •

edited

Loading

Croydon Jul 19, 2021

SpaceIm Jul 21, 2021 •

edited

Loading

This comment has been minimized.

ericLemanissier commented Jul 20, 2021

Croydon commented Jul 20, 2021

ericLemanissier commented Jul 20, 2021

Croydon commented Jul 21, 2021 •

edited

Loading

Croydon commented Jul 21, 2021

add sdl2_image/2.0.5 and sdl2_mixer/2.0.4 #1317

add sdl2_image/2.0.5 and sdl2_mixer/2.0.4 #1317

Conversation

Croydon commented Dec 13, 2020 • edited Loading

Croydon commented Dec 13, 2020

Croydon commented Dec 13, 2020

ericLemanissier commented Dec 14, 2020 • edited Loading

Croydon commented Dec 14, 2020

Croydon commented Dec 14, 2020

ericLemanissier commented Dec 14, 2020 • edited Loading

Croydon commented Dec 14, 2020

ericLemanissier commented Dec 14, 2020

Croydon commented Dec 15, 2020

Croydon commented Dec 15, 2020

ericLemanissier commented Dec 15, 2020

Croydon commented Dec 15, 2020

ericLemanissier commented Dec 15, 2020

Croydon commented Dec 15, 2020

Croydon commented Dec 15, 2020

Croydon commented Dec 15, 2020

SpaceIm Feb 6, 2021 • edited Loading

Choose a reason for hiding this comment

Croydon Jul 19, 2021

Choose a reason for hiding this comment

SpaceIm Jul 21, 2021 • edited Loading

Choose a reason for hiding this comment

This comment has been minimized.

ericLemanissier commented Jul 20, 2021

Croydon commented Jul 20, 2021

ericLemanissier commented Jul 20, 2021

Croydon commented Jul 21, 2021 • edited Loading

Croydon commented Jul 21, 2021

Croydon commented Dec 13, 2020 •

edited

Loading

ericLemanissier commented Dec 14, 2020 •

edited

Loading

ericLemanissier commented Dec 14, 2020 •

edited

Loading

SpaceIm Feb 6, 2021 •

edited

Loading

SpaceIm Jul 21, 2021 •

edited

Loading

Croydon commented Jul 21, 2021 •

edited

Loading