Skip to content
This repository has been archived by the owner on Jan 4, 2021. It is now read-only.

Update to r21 #6

Merged
merged 3 commits into from
Jan 18, 2020
Merged

Update to r21 #6

merged 3 commits into from
Jan 18, 2020

Conversation

vok1980
Copy link

@vok1980 vok1980 commented Jan 17, 2020

No description provided.

@vok1980
Copy link
Author

vok1980 commented Jan 17, 2020

Target branch needs to be corrected.

@vok1980 vok1980 requested a review from SSE4 January 17, 2020 06:58
@Croydon
Copy link
Member

Croydon commented Jan 17, 2020

Is Windows 32bit support official removed by upstream?
If Clang < 9 support official removed by upstream?

Could you please point me to some document saying this?

@cajus
Copy link

cajus commented Jan 17, 2020

For whatever reason it's clang 9.0 instead of 9 for me.

@Croydon Croydon changed the base branch from testing/r20b to testing/r21 January 17, 2020 09:31
@vok1980
Copy link
Author

vok1980 commented Jan 17, 2020

Is Windows 32bit support official removed by upstream?
Could you please point me to some document saying this?

32-bit Windows is no longer supported. This does not affect the vast majority of users. If you do still need to build NDK apps from 32-bit versions of Windows, continue using NDK r20.
https://github.com/android/ndk/wiki/Changelog-r21

@vok1980
Copy link
Author

vok1980 commented Jan 17, 2020

If Clang < 9 support official removed by upstream?
Could you please point me to some document saying this?

Updated Clang and LLD to r365631.
see https://github.com/crDroidMod/android_prebuilts_clang_host_linux-x86_clang-5799447
https://github.com/android/ndk/wiki/Changelog-r21

@vok1980
Copy link
Author

vok1980 commented Jan 17, 2020

@rikdev , FYI

Copy link
Member

@Croydon Croydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the two .travis.yml entries related to ARCH=x86

@vok1980
Copy link
Author

vok1980 commented Jan 18, 2020

Please remove the two .travis.yml entries related to ARCH=x86

I guess, you mean 'ARCH_BUILD: x86', not 'ARCH'.

@vok1980
Copy link
Author

vok1980 commented Jan 18, 2020

BTW, guys, you have settings['compiler.libcxx'] = 'libc++' in build.py and simultaneously

if not str(self.settings.compiler.libcxx) in ["c++_shared", "c++_static"]:
            raise ConanInvalidConfiguration("only libc++ standard library is supported")

in conanfile.py. One of this need to be fixed. Please, see #7

You can see travis now reporting:

Skipped configuration by the recipe: android_ndk_installer/r21@bincrafters/testing: Invalid configuration: only libc++ standard library is supported

@vok1980 vok1980 requested a review from Croydon January 18, 2020 02:12
@SSE4 SSE4 merged commit d15db94 into bincrafters:testing/r21 Jan 18, 2020
@Croydon
Copy link
Member

Croydon commented Jan 18, 2020

I guess, you mean 'ARCH_BUILD: x86', not 'ARCH'.

No, I meant ARCH because I was talking about the .travis.yml file not the appveyor.yml

@vok1980 vok1980 deleted the testing/r21 branch January 19, 2020 01:28
@vok1980
Copy link
Author

vok1980 commented Jan 19, 2020

I guess, you mean 'ARCH_BUILD: x86', not 'ARCH'.

No, I meant ARCH because I was talking about the .travis.yml file not the appveyor.yml

There is no reason to remove ARCH x86. Android x86 arch still supported.
32-bit Windows is no longer supported -- it means that we can't build on 32-bit windows. In terms of conan, ARCH_BUILD x86 for PLATFORM windows need to be removed.
I see, you removed ARCH x86 for linux and osx in .travis.yml in commit 0f1e9c4. Please revert it.
@SSE4 FYI

@SSE4
Copy link
Member

SSE4 commented Jan 19, 2020

right, I'll revert

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants