Android fixes/1.66.0 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mful Signed-off-by: SSE4 <tomskside@gmail.com>
Signed-off-by: SSE4 <tomskside@gmail.com>
Signed-off-by: SSE4 <tomskside@gmail.com>
…, RANLIB, etc.), useful for cross-compilation (e.g. Android) Signed-off-by: SSE4 <tomskside@gmail.com>
grafikrobot
requested changes
May 11, 2018
conanfile.py
Outdated
| def b2_profile_tools(self): | ||
| if self.b2_toolset == 'gcc' or self.b2_toolset == 'clang': | ||
| additional_flags = [] | ||
| if 'CONAN_CMAKE_FIND_ROOT_PATH' in os.environ: |
There was a problem hiding this comment.
I don't think it's a good idea to add special cases for cmake in a b2 specific generator. And reading the docs on cmake_find_roo_path it doesn't seem all to be relevant to the b2 feature.
There was a problem hiding this comment.
changed, thanks for the feedback
Signed-off-by: SSE4 <tomskside@gmail.com>
grafikrobot
approved these changes
May 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to the bincrafters/community#189
-stdlib=libc++, as it's harmful, and standalone toolchain already has the only standard library it is configured for. more,-stdlib=libc++implies-lc++, but standlone toolchain doesn't have libc++.a/libc++.so, only libc++_shared.so and libc++_static.a (which are auto-linked anyway). more information: Android and CONAN_LIBCXX do not play well together conan-io/conan#2402 C++ headers are not found when cross-building for Android conan-io/conan#2049