Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Change UpdateTemplate function declaration #10

Closed

Conversation

captainsafia
Copy link
Contributor

Closes #8.

@captainsafia
Copy link
Contributor Author

Having a problem with this @rgbkrk so leaving a note here for whenever you can get to it.

I'm having an issue when trying to run go tests, specifically with the mocks. Since I altered the store interface I ran $GOPATH/bin/mockery --all to regenerate the mocks which are then stored in the mocks folder. However, the setupHandlersTests function in handlers_test.go refers to the mockStore struct in registry_test.go which isn't updated when I run mockery. I'm not entire sure why the Store mock was set up this way either. Furthermore, how exactly was the mockStore created?

Let me know if any of that doesn't make sense.

@rgbkrk
Copy link
Member

rgbkrk commented Oct 27, 2015

I shoe horned the mockStore into working. The reflection was not working well so I wrote a way to work with it. We can and should do those differently.

@captainsafia
Copy link
Contributor Author

Hm I see. I'll give refactoring the mocks ago. Right now, if you trying using mocks.Store you get all the import cycle errors one can possibly contain in a 80 character by 194 character terminal.

@captainsafia
Copy link
Contributor Author

gopher_gorequest_400x300

Me working on binder-registry looks a lot like this.

@captainsafia
Copy link
Contributor Author

Wow. More than 4 years ago. Time to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants