Merge pull request #34 from bingnz/propagate-less-errors

fix: propagate errors that occur when parsing less imports.
bingnz · Apr 9, 2019 · e266910 · e266910
2 parents 11ac4b9 + 69c2815
commit e266910
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 24 deletions.
diff --git a/src/import-buffer.ts b/src/import-buffer.ts
@@ -42,13 +42,8 @@ export class ImportBuffer {
 
   public async listImports(file: File): Promise<IFileInfo[]> {
     const useImportLister: () => Promise<IFileInfo[]> = async () => {
-      try {
-        const importListerResults = await this.importLister(file);
-        return await this.cacheResults(file.path, importListerResults);
-      } catch (error) {
-        console.error(`An unknown error occurred: ${error}`);
-        return [];
-      }
+      const importListerResults = await this.importLister(file);
+      return this.cacheResults(file.path, importListerResults);
     };
 
     const existingImports = await this.loadPreviousResults(file.path);

diff --git a/test/import-buffer.js b/test/import-buffer.js
@@ -357,25 +357,12 @@ describe("import-buffer", () => {
             ]);
         });
 
-        it("should return no imports if unknown error occurs", async () => {
+        it("should propagate error if unknown error occurs", async () => {
             var fakeError = new Error("test");
             fakeError.code = "SOMEERR";
             spyContext.stub(fsStub, "stat").throws(fakeError);
 
-            const imports = await buffer.listImports(mainFile);
-            expect(imports).to.be.empty;
-        });
-
-        it("should log error if unknown error occurs", async () => {
-            const fakeError = new Error("test");
-            fakeError.code = "SOMEERR";
-            spyContext.stub(fsStub, "stat").throws(fakeError);
-            spyContext.spy(console, "error");
-
-            await buffer.listImports(mainFile);
-            expect(console.error).to.have.been.calledWith(
-                "An unknown error occurred: Error: test"
-            );
+            await expect(buffer.listImports(mainFile)).to.eventually.be.rejectedWith(Error, "test");
         });
 
         it("should not cache results if unknown error occurs", async () => {
@@ -385,10 +372,11 @@ describe("import-buffer", () => {
             newSpyContext.stub(fsStub, "stat").throws(fakeError);
             newSpyContext.spy(console, "error");
 
-            let imports = await buffer.listImports(mainFile);
+            await expect(buffer.listImports(mainFile)).to.eventually.be.rejectedWith();
+
             newSpyContext.restore();
 
-            imports = await buffer.listImports(mainFile);
+            const imports = await buffer.listImports(mainFile);
             expect(imports).not.to.be.empty;
         });
     });