Loop argument parsing issue

[angelhof]

The loop1.sh testcase (simplified from a POSIX test) is parsed wrongly by pash which only parses the first loop argument A and not B.

One can reproduce this by running $PASH_TOP/pa.sh -d 1 loop1.sh with the added logs in this branch to see that it is a parsing issue.

@thurstond, @mgree do you have any ideas what could be the problem?

[thurstond]

I've just committed 2476ec0, which changes the for loop parsing (and unparsing) from "arg" to "args".

Note that this necessarily breaks the API i.e., for parsed loop1.sh, notice the arguments has an extra layer of nesting:

["For", [1, [[["C", 65]], [["C", 66]]], ["Command", [2, [], [[["C", 101], ["C", 99], ["C", 104], ["C", 111]], [["V", ["Normal", false, "idFor1", []]]]], []]], "idFor1"]]

@mgree If this change is correct, your upstream OCaml code needs a similar tweak.

[thurstond]

My branch is slightly out of sync so I will merge the braces change back in.

[mgree]

Good catch! It's not an issue for Smoosh because the actual AST shim does the right thing, but it's definitely wrong in the libdash AST. Thanks! I'll make an issue for libdash.

[angelhof]

Thanks everyone!