Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify dgsh-wrapper ... #595

Merged

Conversation

festutz
Copy link
Collaborator

@festutz festutz commented Jun 29, 2022

... to not require operands before options but pass options for input and output directly

Signed-off-by: Felix Stutz fstutz@mpi-sws.org

…ptions for input and output directly

Signed-off-by: Felix Stutz <fstutz@mpi-sws.org>
@festutz festutz requested a review from angelhof June 29, 2022 14:34
@festutz
Copy link
Collaborator Author

festutz commented Jun 29, 2022

The wrapper for dgsh_tee uses and modifies PASH_TOP. This is why I decided to amend the wrapper-script to just pass all options (which now also contain input and output) instead of by-passing it.
If safe to by-pass, it should be easy to do so.

@festutz festutz merged commit f6a3df1 into future_annotations Jun 29, 2022
@festutz festutz deleted the future_annotations_dgsh_tee_wrapper_call branch June 29, 2022 14:39
@github-actions
Copy link

OS:ubuntu-18.04
Wed Jun 29 14:59:05 UTC 2022
intro: 0/2 tests passed.
interface: 6/38 tests passed.
compiler: 0/54 tests passed.
agg: 10/109 tests passed.
demo-spell.sh are not identical
hello-world.sh are not identical
test1 are not identical
test2 are not identical
test3 are not identical
test4 are not identical
test5 are not identical
test6 are not identical
test8 are not identical
test9 are not identical
test10 are not identical
test12 are not identical
test13 are not identical
test14 are not identical
test15 are not identical
test16 are not identical
test17 are not identical
test18 are not identical
test_set are not identical
test_set_e are not identical
test_redirect are not identical
test_unparsing are not identical
test_set_e_2 are not identical
test_set_e_3 are not identical
test_new_line_in_var are not identical
test_cmd_sbst are not identical
test_cmd_sbst2 are not identical
test_cat_hyphen are not identical
test_trap are not identical
test_umask are not identical
test_quoting are not identical
test_var_assgn_default are not identical
test_exclam are not identical
test_redir_var_test are not identical
diff.sh are not identical
diff.sh are not identical
set-diff.sh are not identical
set-diff.sh are not identical
export_var_script.sh are not identical
export_var_script.sh are not identical
comm-par-test.sh are not identical
comm-par-test.sh are not identical
comm-par-test2.sh are not identical
comm-par-test2.sh are not identical
tee_web_index_bug.sh are not identical
tee_web_index_bug.sh are not identical
fun-def.sh are not identical
fun-def.sh are not identical
bigrams.sh are not identical
bigrams.sh are not identical
spell-grep.sh are not identical
spell-grep.sh are not identical
grep.sh are not identical
grep.sh are not identical
minimal_sort.sh are not identical
minimal_sort.sh are not identical
minimal_grep.sh are not identical
minimal_grep.sh are not identical
topn.sh are not identical
topn.sh are not identical
wf.sh are not identical
wf.sh are not identical
spell.sh are not identical
spell.sh are not identical
shortest_scripts.sh are not identical
shortest_scripts.sh are not identical
alt_bigrams.sh are not identical
alt_bigrams.sh are not identical
deadlock_test.sh are not identical
deadlock_test.sh are not identical
double_sort.sh are not identical
double_sort.sh are not identical
no_in_script.sh are not identical
no_in_script.sh are not identical
for_loop_simple.sh are not identical
for_loop_simple.sh are not identical
minimal_grep_stdin.sh are not identical
minimal_grep_stdin.sh are not identical
micro_10.sh are not identical
micro_10.sh are not identical
sed-test.sh are not identical
sed-test.sh are not identical
tr-test.sh are not identical
tr-test.sh are not identical
grep-test.sh are not identical
grep-test.sh are not identical
ann-agg.sh are not identical
ann-agg.sh are not identical
test-1 are not identical
test-2 are not identical
test-3 are not identical
test-4 are not identical
test-5 are not identical
test-6 are not identical
test-7 are not identical
test-10 are not identical
test-11 are not identical
test-12 are not identical
test-13 are not identical
test-14 are not identical
test-17 are not identical
test-18 are not identical
test-21 are not identical
test-24 are not identical
test-25 are not identical
test-28 are not identical
test-30 are not identical
test-31 are not identical
test-32 are not identical
test-34 are not identical
test-35 are not identical
test-36 are not identical
test-38 are not identical
test-40 are not identical
test-41 are not identical
test-42 are not identical
test-43 are not identical
test-45 are not identical
test-46 are not identical
test-47 are not identical
test-48 are not identical
test-50 are not identical
test-51 are not identical
test-52 are not identical
test-53 are not identical
test-55 are not identical
test-56 are not identical
test-58 are not identical
test-62 are not identical
test-63 are not identical
test-70 are not identical
test-73 are not identical
test-82 are not identical
test-84 are not identical
test-89 are not identical
test-90 are not identical
test-93 are not identical
test-95 are not identical
test-96 are not identical
test-97 are not identical
test-98 are not identical
test-99 are not identical
test-100 are not identical
test-101 are not identical
test-102 are not identical
test-103 are not identical
test-104 are not identical
test-105 are not identical
test-106 are not identical
test-107 are not identical
test-108 are not identical
test-109 are not identical
test-110 are not identical
test-111 are not identical
test-113 are not identical
test-114 are not identical
test-115 are not identical
test-116 are not identical
test-117 are not identical
test-118 are not identical
test-120 are not identical
test-121 are not identical
test-122 are not identical
test-123 are not identical
test-125 are not identical
test-129 are not identical
test-130 are not identical
test-131 are not identical
test-140 are not identical
test-149 are not identical
test-150 are not identical
test-152 are not identical
test-153 are not identical
test-160 are not identical
test-163 are not identical
test-165 are not identical
test-170 are not identical
test-175 are not identical
test-176 are not identical
test-177 are not identical
test-178 are not identical
test-179 are not identical
test-180 are not identical
test-181 are not identical
test-182 are not identical
test-187 are not identical
test-192 are not identical

@github-actions
Copy link

OS:ubuntu-20.04
Wed Jun 29 14:59:07 UTC 2022
intro: 0/2 tests passed.
interface: 6/38 tests passed.
compiler: 0/54 tests passed.
agg: 10/109 tests passed.
demo-spell.sh are not identical
hello-world.sh are not identical
test1 are not identical
test2 are not identical
test3 are not identical
test4 are not identical
test5 are not identical
test6 are not identical
test8 are not identical
test9 are not identical
test10 are not identical
test12 are not identical
test13 are not identical
test14 are not identical
test15 are not identical
test16 are not identical
test17 are not identical
test18 are not identical
test_set are not identical
test_set_e are not identical
test_redirect are not identical
test_unparsing are not identical
test_set_e_2 are not identical
test_set_e_3 are not identical
test_new_line_in_var are not identical
test_cmd_sbst are not identical
test_cmd_sbst2 are not identical
test_cat_hyphen are not identical
test_trap are not identical
test_umask are not identical
test_quoting are not identical
test_var_assgn_default are not identical
test_exclam are not identical
test_redir_var_test are not identical
diff.sh are not identical
diff.sh are not identical
set-diff.sh are not identical
set-diff.sh are not identical
export_var_script.sh are not identical
export_var_script.sh are not identical
comm-par-test.sh are not identical
comm-par-test.sh are not identical
comm-par-test2.sh are not identical
comm-par-test2.sh are not identical
tee_web_index_bug.sh are not identical
tee_web_index_bug.sh are not identical
fun-def.sh are not identical
fun-def.sh are not identical
bigrams.sh are not identical
bigrams.sh are not identical
spell-grep.sh are not identical
spell-grep.sh are not identical
grep.sh are not identical
grep.sh are not identical
minimal_sort.sh are not identical
minimal_sort.sh are not identical
minimal_grep.sh are not identical
minimal_grep.sh are not identical
topn.sh are not identical
topn.sh are not identical
wf.sh are not identical
wf.sh are not identical
spell.sh are not identical
spell.sh are not identical
shortest_scripts.sh are not identical
shortest_scripts.sh are not identical
alt_bigrams.sh are not identical
alt_bigrams.sh are not identical
deadlock_test.sh are not identical
deadlock_test.sh are not identical
double_sort.sh are not identical
double_sort.sh are not identical
no_in_script.sh are not identical
no_in_script.sh are not identical
for_loop_simple.sh are not identical
for_loop_simple.sh are not identical
minimal_grep_stdin.sh are not identical
minimal_grep_stdin.sh are not identical
micro_10.sh are not identical
micro_10.sh are not identical
sed-test.sh are not identical
sed-test.sh are not identical
tr-test.sh are not identical
tr-test.sh are not identical
grep-test.sh are not identical
grep-test.sh are not identical
ann-agg.sh are not identical
ann-agg.sh are not identical
test-1 are not identical
test-2 are not identical
test-3 are not identical
test-4 are not identical
test-5 are not identical
test-6 are not identical
test-7 are not identical
test-10 are not identical
test-11 are not identical
test-12 are not identical
test-13 are not identical
test-14 are not identical
test-17 are not identical
test-18 are not identical
test-21 are not identical
test-24 are not identical
test-25 are not identical
test-28 are not identical
test-30 are not identical
test-31 are not identical
test-32 are not identical
test-34 are not identical
test-35 are not identical
test-36 are not identical
test-38 are not identical
test-40 are not identical
test-41 are not identical
test-42 are not identical
test-43 are not identical
test-45 are not identical
test-46 are not identical
test-47 are not identical
test-48 are not identical
test-50 are not identical
test-51 are not identical
test-52 are not identical
test-53 are not identical
test-55 are not identical
test-56 are not identical
test-58 are not identical
test-62 are not identical
test-63 are not identical
test-70 are not identical
test-73 are not identical
test-82 are not identical
test-84 are not identical
test-89 are not identical
test-90 are not identical
test-93 are not identical
test-95 are not identical
test-96 are not identical
test-97 are not identical
test-98 are not identical
test-99 are not identical
test-100 are not identical
test-101 are not identical
test-102 are not identical
test-103 are not identical
test-104 are not identical
test-105 are not identical
test-106 are not identical
test-107 are not identical
test-108 are not identical
test-109 are not identical
test-110 are not identical
test-111 are not identical
test-113 are not identical
test-114 are not identical
test-115 are not identical
test-116 are not identical
test-117 are not identical
test-118 are not identical
test-120 are not identical
test-121 are not identical
test-122 are not identical
test-123 are not identical
test-125 are not identical
test-129 are not identical
test-130 are not identical
test-131 are not identical
test-140 are not identical
test-149 are not identical
test-150 are not identical
test-152 are not identical
test-153 are not identical
test-160 are not identical
test-163 are not identical
test-165 are not identical
test-170 are not identical
test-175 are not identical
test-176 are not identical
test-177 are not identical
test-178 are not identical
test-179 are not identical
test-180 are not identical
test-181 are not identical
test-182 are not identical
test-187 are not identical
test-192 are not identical

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant