Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize pash_runtime #665

Merged
merged 14 commits into from
Apr 21, 2023
Merged

Reorganize pash_runtime #665

merged 14 commits into from
Apr 21, 2023

Conversation

angelhof
Copy link
Member

No description provided.

@github-actions
Copy link

OS:ubuntu-20.04
Wed Apr 19 05:05:36 UTC 2023
intro: 2/2 tests passed.
interface: 39/39 tests passed.
compiler: 54/54 tests passed.
agg: 109/109 tests passed.

@github-actions
Copy link

OS = Debian 10
CPU = Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz
Ram = 15752
Hash = 00885b5
Kernel= Linux 4.15.0-197-generic x86_64

benchmark tests passed failed untested unresolved unsupported not_in_use other_status
posix 494 375 41 31 6 40 1 0
intro 2 2 0 0 0 0 0 0
interface 39 39 0 0 0 0 0 0
compiler 54 54 0 0 0 0 0 0
aggregator 109 109 0 0 0 0 0 0

@github-actions
Copy link

OS:ubuntu-20.04
Wed Apr 19 14:22:38 UTC 2023
intro: 2/2 tests passed.
interface: 39/39 tests passed.
compiler: 54/54 tests passed.
agg: 109/109 tests passed.

Signed-off-by: Konstantinos Kallas <konstantinos.kallas@hotmail.com>
Signed-off-by: Konstantinos Kallas <konstantinos.kallas@hotmail.com>
Signed-off-by: Konstantinos Kallas <konstantinos.kallas@hotmail.com>
Signed-off-by: Konstantinos Kallas <konstantinos.kallas@hotmail.com>
Signed-off-by: Konstantinos Kallas <konstantinos.kallas@hotmail.com>
Signed-off-by: Konstantinos Kallas <konstantinos.kallas@hotmail.com>
Signed-off-by: Konstantinos Kallas <konstantinos.kallas@hotmail.com>
Signed-off-by: Konstantinos Kallas <konstantinos.kallas@hotmail.com>
@binpash binpash deleted a comment from github-actions bot Apr 19, 2023
@binpash binpash deleted a comment from github-actions bot Apr 19, 2023
@github-actions
Copy link

OS:ubuntu-20.04
Wed Apr 19 14:34:40 UTC 2023
intro: 2/2 tests passed.
interface: 39/39 tests passed.
compiler: 54/54 tests passed.
agg: 109/109 tests passed.

@github-actions
Copy link

OS:ubuntu-20.04
Wed Apr 19 16:16:19 UTC 2023
intro: 2/2 tests passed.
interface: 39/39 tests passed.
compiler: 54/54 tests passed.
agg: 109/109 tests passed.

Signed-off-by: Konstantinos Kallas <konstantinos.kallas@hotmail.com>
@github-actions
Copy link

OS:ubuntu-20.04
Wed Apr 19 20:22:10 UTC 2023
intro: 2/2 tests passed.
interface: 39/39 tests passed.
compiler: 54/54 tests passed.
agg: 109/109 tests passed.

Signed-off-by: Konstantinos Kallas <konstantinos.kallas@hotmail.com>
@github-actions
Copy link

OS:ubuntu-20.04
Wed Apr 19 20:30:47 UTC 2023
intro: 2/2 tests passed.
interface: 39/39 tests passed.
compiler: 54/54 tests passed.
agg: 109/109 tests passed.

@github-actions
Copy link

OS:ubuntu-20.04
Thu Apr 20 16:31:40 UTC 2023
intro: 2/2 tests passed.
interface: 39/39 tests passed.
compiler: 54/54 tests passed.
agg: 109/109 tests passed.

@github-actions
Copy link

OS = Debian 10
CPU = Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz
Ram = 15752
Hash = 991020c
Kernel= Linux 4.15.0-197-generic x86_64

benchmark tests passed failed untested unresolved unsupported not_in_use other_status
posix 494 374 42 31 6 40 1 0
intro 2 2 0 0 0 0 0 0
interface 39 39 0 0 0 0 0 0
compiler 54 54 0 0 0 0 0 0
aggregator 109 109 0 0 0 0 0 0

@github-actions
Copy link

OS:ubuntu-20.04
Fri Apr 21 13:58:38 UTC 2023
intro: 2/2 tests passed.
interface: 40/40 tests passed.
compiler: 54/54 tests passed.
agg: 109/109 tests passed.

@github-actions
Copy link

OS = Debian 10
CPU = Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz
Ram = 15752
Hash = fe8bb7f
Kernel= Linux 4.15.0-197-generic x86_64

benchmark tests passed failed untested unresolved unsupported not_in_use other_status
posix 494 375 41 31 6 40 1 0
intro 2 2 0 0 0 0 0 0
interface 40 40 0 0 0 0 0 0
compiler 54 54 0 0 0 0 0 0
aggregator 109 109 0 0 0 0 0 0

@angelhof
Copy link
Member Author

This PR significantly cleans up the pash runtime. It is now ready to make it an external library. @mgree we can discuss the preferred interface of such a library at some point. What would be the most useful interface. I am thinking something along the lines of:

## Wraps a SCRIPT with a PRE and POST script while making sure to hide this wrapping from SCRIPT
##   by passing it the correct error code and propagating its error code outside while also not resetting `set` state
##   while executing the PRE and POST scripts.
wrap PRE_SCRIPT SCRIPT [POST_SCRIPT]

If we can think of a couple usecases too we can add a cute README and publicize this library as its own repo.

@angelhof angelhof merged commit 8969acd into future Apr 21, 2023
@angelhof angelhof deleted the separate-save-state branch April 21, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant