Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply changes properly when using multiple lowerdirs #142

Open
ezrizhu opened this issue Jan 13, 2024 · 0 comments
Open

apply changes properly when using multiple lowerdirs #142

ezrizhu opened this issue Jan 13, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ezrizhu
Copy link
Collaborator

ezrizhu commented Jan 13, 2024 •
edited
Loading

Talking with @angelhof about this, we realized there's a tricky interaction with process_changes when you have multiple lowerdirs: you have to replay the merge to do the comparison.
The correct solution is to mergerfs mount the layers of lowerdir and compare against that merged lowerdir (rather than the $local_file which just absolutizes to the real system root).
But until we have a use case where someone would want to use summaries and multiple lowerdirs (hs doesn't want the summaries), we should punt on this and give a warning that -L implies -n.

Originally posted by @mgree in #122 (comment)
@ezrizhu ezrizhu added the enhancement New feature or request label Jan 13, 2024
ezrizhu added a commit that referenced this issue Jan 13, 2024
@gliargovas @ezrizhu
Implement Multi-Lower-Layer Overlay Support through Merging (#122)
0647f69 
* feat: add -L flag to support one or more lower directories

* docs: shell completion, manpage, and readme update

* test: add test to test merging multiple lowerdirs, and also invoking -L multiple times

Note that currently -L implies -n (will not commit changes), support for that is being tracked in  #142

---------

Co-authored-by: gliargovas <gliarovas@aueb.gr>
Co-authored-by: Ezri Zhu <me@ezrizhu.com>
Reviewed-by: Michael Greenberg <michael.greenberg@stevens.edu>
Reviewed-by: Konstantinos Kallas <konstantinos.kallas@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ezrizhu