Properly mkdir when file exists at the same path and refactor
#83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgree
approved these changes
Jun 28, 2023
| summary_output=$(process_changes "$SANDBOX_DIR" "$changed_files") | ||
|
|
||
| while IFS= read -r summary_line; do | ||
| local_file="$(echo "$summary_line" | cut -c 4-)" |
There was a problem hiding this comment.
This logic is good, but could break with particularly nasty filenames (e.g., newlines). The most robust approach is to null terminate, à la find ... -print0 or xargs -0.
There was a problem hiding this comment.
Great, will add an issue so that we can properly fix it (add the necessary tests). We can merge this for now (since it is a more impactful fix).
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up the summary/commit logic to use the same core, and fixed the bug in #18