Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing overlhaul and refactoring #92

Merged
merged 29 commits into from
Jul 6, 2023
Merged

Testing overlhaul and refactoring #92

merged 29 commits into from
Jul 6, 2023

Conversation

angelhof
Copy link
Member

@angelhof angelhof commented Jun 29, 2023

Testing overhaul and refactoring. Cleanup of temporary files is left for a new PR at a later time.

OLD: Replaces #66 and implements only part of its functionality (it doesn't try to clean up the overlay directories).

@angelhof
Copy link
Member Author

So the cleanup test is not passing, however some of the temporary files/directories that are shown in the diff are not created by us; I have added a print before the cleanup to see what files are to be cleaned up (except if I am missing something).

Maybe these temp files are created by mergerfs? I wouldn't consider this impossible. That brings me the following thought. Why do we even want to delete the temporary log/auxilliary files? They are useful for debugging, and they are tiny. I think the only thing we actually want to delete is any left state from overlayfs, any mounts that we did, and the upperdir (which could get big). Everything else doesn't need to be deleted. Based on that, I think we should properly investigate what state does overlayfs leave behind and discuss how to solve this issue in #93 and only merge the testing overhaul from this (#92) PR.

@angelhof
Copy link
Member Author

angelhof commented Jul 5, 2023

@mgree what do you think about my comment above? Is it OK if we merge the testing overhaul from here and leave cleanup for a proper PR in the future after 0.2 (after we properly understand what state overlayfs leaves behind).

@mgree
Copy link
Contributor

mgree commented Jul 6, 2023

Yes, I think that's fine.

@angelhof angelhof changed the title Cleanup temporary files (replaces #66) Testing overlhaul and refactoring Jul 6, 2023
@angelhof angelhof merged commit 94b4fec into main Jul 6, 2023
@angelhof angelhof deleted the new-cleanup branch July 6, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants