-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing overlhaul and refactoring #92
Conversation
So the cleanup test is not passing, however some of the temporary files/directories that are shown in the diff are not created by us; I have added a print before the cleanup to see what files are to be cleaned up (except if I am missing something). Maybe these temp files are created by mergerfs? I wouldn't consider this impossible. That brings me the following thought. Why do we even want to delete the temporary log/auxilliary files? They are useful for debugging, and they are tiny. I think the only thing we actually want to delete is any left state from overlayfs, any mounts that we did, and the upperdir (which could get big). Everything else doesn't need to be deleted. Based on that, I think we should properly investigate what state does overlayfs leave behind and discuss how to solve this issue in #93 and only merge the testing overhaul from this (#92) PR. |
@mgree what do you think about my comment above? Is it OK if we merge the testing overhaul from here and leave cleanup for a proper PR in the future after 0.2 (after we properly understand what state overlayfs leaves behind). |
Yes, I think that's fine. |
Testing overhaul and refactoring. Cleanup of temporary files is left for a new PR at a later time.
OLD: Replaces #66 and implements only part of its functionality (it doesn't try to clean up the overlay directories).