Skip to content

Support multiple subscriptions #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Support multiple subscriptions #19

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2cce8db
Support multiple subscriptions
mantiz Aug 8, 2020
42f24c8
Don't use splat operator for arrays
mantiz Aug 8, 2020
691b538
Improve forwarding of subscriptions arguments
mantiz Aug 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ReactMqttClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,13 +274,13 @@ function () {
/**
* Subscribes to a topic filter.
*/
public function subscribe(Subscription $subscription): ExtendedPromiseInterface
public function subscribe(Subscription $subscription, Subscription ...$subscriptions): ExtendedPromiseInterface
{
if (!$this->isConnected) {
return new RejectedPromise(new LogicException('The client is not connected.'));
}

return $this->startFlow($this->flowFactory->buildOutgoingSubscribeFlow([$subscription]));
return $this->startFlow($this->flowFactory->buildOutgoingSubscribeFlow(func_get_args()));
}

/**
Expand Down