Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example deployment #457

Closed
l-maciej opened this issue Oct 30, 2022 · 5 comments
Closed

Example deployment #457

l-maciej opened this issue Oct 30, 2022 · 5 comments
Labels
docs Improvements or additions to documentation

Comments

@l-maciej
Copy link
Contributor

Hi
I would like to add an example of kustomize-based Kubernetes deployment to the documentation.
This one is quite basic but it can be worked on.

k8s-deployment.zip

@binwiederhier
Copy link
Owner

There's a brand new section on K8s here: https://github.com/binwiederhier/ntfy/blob/main/docs/install.md#kubernetes -- Mabye you can see if your matches or overlaps and enhance it? Look at the raw source, not the rendered md file. It'll look different when the docs are generated.

@binwiederhier binwiederhier added the docs Improvements or additions to documentation label Oct 30, 2022
@l-maciej
Copy link
Contributor Author

I've packed raw yaml files.
I'll take look tomorrow and create doc pages.

@l-maciej
Copy link
Contributor Author

install.md
I've added a new section, my deployment is structured bit differently. It still might need some polish and adjustments ;)

@binwiederhier
Copy link
Owner

Instead of uploading a new file, could you instead create a pull request against the main branch? If you don't know how that works, there's a video here that explains it: https://www.youtube.com/watch?v=rgbCcBNZcdQ

@l-maciej
Copy link
Contributor Author

l-maciej commented Nov 2, 2022

PR-463
Thanks for the link ! I've never worked with this method of creating PR's

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants