-
-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created documentation for kustomization deployment #463
Conversation
docs/install.md
Outdated
@@ -185,8 +185,6 @@ ntfy is packaged in nixpkgs as `ntfy-sh`. It can be installed by adding the pack | |||
nix-env -iA ntfy-sh | |||
``` | |||
|
|||
NixOS also supports [declarative setup of the ntfy server](https://search.nixos.org/options?channel=unstable&show=services.ntfy-sh.enable&from=0&size=50&sort=relevance&type=packages&query=ntfy). | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your branch seems to be out of date. Pull the latest changes via git pull upstream main
("upstream" is the remote https://github.com/binwiederhier/ntfy, Google git remote add
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line restored
👍 Thank you for your PR. I left some comments, which you'd need to address before I can merge it. Usually I just merge it and then do the format fixes later, but the PR is too extensive to do that myself. |
Your branch is still not up-to-date, and you've change permissions on various files (see "Files" tab in this PR). Do this to update your branch:
You'll still need to revert the file permissions. |
Ping. |
Your branch is still not up-to-date, and you've change permissions on various files (see "Files" tab in this PR). Do this to update your branch: git remote add upstream git@github.com:binwiederhier/ntfy.git |
Hi I've reverted permissions and pulled in fresh changes from the main branch. |
Almost there. If you look at the diff https://github.com/binwiederhier/ntfy/pull/463/files (see https://github.com/binwiederhier/ntfy/pull/463/files#diff-162b45a313f5f057a233411edbe31e72a13185f4df0ae0e1af2c13521bc05d5aL188), you'll see that the is a string that your PR removes that is entirely unrelated. That should be fixed by pulling from upstream as described above. If you can't figure out how, I can do it :) |
Looks good. Thanks. |
Initial commit for kustomization-based deployment.