Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full feature message example #234

Merged
merged 15 commits into from
May 5, 2022
Merged

Full feature message example #234

merged 15 commits into from
May 5, 2022

Conversation

aTable
Copy link
Contributor

@aTable aTable commented May 4, 2022

Currently, it's not obvious that a multiline message is possible as all the examples are single lines. This change helps bring attention to that however, it does throw the nice language alignment out a bit as this is the only snippet on the whole page that is a bash shell and not direct curl commands.

Ideally, all the supported languages are filled out and not // TODO but what are you thoughts to this change?

@binwiederhier
Copy link
Owner

binwiederhier commented May 4, 2022

Thank you for contributing. I love the idea of having another example at the top. We've added many features, so why not use this spot to show some of them. You could, for instance, show

  • multiline
  • click action
  • action buttons
  • delayed delivery

all in one example.

What do you think? We should probably also pick an interesting multiline example, and not re-use the one from above.

@aTable
Copy link
Contributor Author

aTable commented May 4, 2022

Makes sense! I went with a roadworks theme just to get it started - happy for it to change

@aTable aTable changed the title Multiline message example Full feature message example May 4, 2022
@binwiederhier
Copy link
Owner

Sorry for the back and forth, but this is prime real estate in terms of docs, so I want the right example there. Your example was good, but not realistic enough, imho. What do you think of the one below? If you fill out the other languages, I'll provide the image.

"You can also do multi-line messages. Here's an example using a click action, a user action, with an external image attachment and forwarded via email:"

curl \
  -H "Click: https://home.nest.com/" \
  -H "Attach: https://nest.com/view/yAxkasd.jpg" \
  -H "Actions: http, Open door, https://api.nest.com/open/yAxkasd, clear=true" \
  -H "Email: phil@example.com" \
  -d "There's someone at the door. 🐶
   
Please check if it's a good boy or a hooman. 
Doggies have been known to ring the doorbell." \
      ntfy.sh/mydoorbell

Screenshot_20220504-191014

1 similar comment
@binwiederhier
Copy link
Owner

Sorry for the back and forth, but this is prime real estate in terms of docs, so I want the right example there. Your example was good, but not realistic enough, imho. What do you think of the one below? If you fill out the other languages, I'll provide the image.

"You can also do multi-line messages. Here's an example using a click action, a user action, with an external image attachment and forwarded via email:"

curl \
  -H "Click: https://home.nest.com/" \
  -H "Attach: https://nest.com/view/yAxkasd.jpg" \
  -H "Actions: http, Open door, https://api.nest.com/open/yAxkasd, clear=true" \
  -H "Email: phil@example.com" \
  -d "There's someone at the door. 🐶
   
Please check if it's a good boy or a hooman. 
Doggies have been known to ring the doorbell." \
      ntfy.sh/mydoorbell

Screenshot_20220504-191014

@aTable aTable marked this pull request as ready for review May 5, 2022 11:14
@aTable
Copy link
Contributor Author

aTable commented May 5, 2022

No dramas, I like your example. I'm doing this from the web IDE so not certain the language syntax for each example is 100% right

@binwiederhier
Copy link
Owner

That's perfectly alright. I do it from my IDE and I've not tested all of the examples either 😬 so no worries. Just do what you can and I'll do the rest.

@binwiederhier
Copy link
Owner

Awesome. Thanks!

@binwiederhier binwiederhier merged commit ea30132 into binwiederhier:main May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants