-
-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch message INSERTs #502
Conversation
Codecov ReportBase: 66.04% // Head: 66.13% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #502 +/- ##
==========================================
+ Coverage 66.04% 66.13% +0.09%
==========================================
Files 35 36 +1
Lines 3723 3795 +72
==========================================
+ Hits 2459 2510 +51
- Misses 910 924 +14
- Partials 354 361 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the new logging messages for every success/failure of adding + processing + pruning every single message in the queue going to bloat your logs?
Anything below INFO logs are not logged by default, only when log-level is DEBUG or TRACE. So I can turn them on and diagnose a little and then turn it off again. The log-level is the only option that can be hot-reloaded from the config without restarting the server. Makes debugging much easier: https://docs.ntfy.sh/config/#debuggingtracing |
No description provided.