Fix suppressed eslint issues #750
Conversation
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #750 +/- ##
=======================================
Coverage 65.76% 65.76%
=======================================
Files 50 50
Lines 7332 7332
=======================================
Hits 4822 4822
Misses 1725 1725
Partials 785 785 ☔ View full report in Codecov by Sentry. |
|
Rebased in #753 -- I'll review this tomorrow. My eyes are getting tired. Good stuff! |
Also updated this branch now if you want to reuse this PR :) |
| } | ||
| return true; | ||
| }; | ||
| const emojiMatches = (emoji, words) => words.length === 0 || words.some((word) => emoji.searchBase.includes(word)); |
There was a problem hiding this comment.
Nit: I don't care enough to revert this, but this is freaking awful :-) It's 100% less readable than the version before. And readability is king.
I kept the changes in the eslint PR to a minimum of simple logic preserving fixes, these could potentially change/break behaviour but are likely correct. Better to review separately.