#161 fix: Standardize deconvolution model outputs#190
Merged
marcbal77 merged 1 commit intobio-learn:masterfrom Jan 6, 2026
Merged
#161 fix: Standardize deconvolution model outputs#190marcbal77 merged 1 commit intobio-learn:masterfrom
marcbal77 merged 1 commit intobio-learn:masterfrom
Conversation
Member
|
Thanks for the contribution @Sprengmeister-dev. The core logic looks correct and addresses the transposed output issue for deconvolution models. Before we can merge, please:
The fix itself is clean and the approach is solid. Once formatting is addressed, this should be good to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardizes deconvolution predict() output to match other models (samples as index, cell types as columns). Updates expected outputs and the deconvolution example accordingly. Fixes #161.