Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload E.Lee BCO #165

Merged
merged 1 commit into from
Oct 16, 2019
Merged

Upload E.Lee BCO #165

merged 1 commit into from
Oct 16, 2019

Conversation

ECL314
Copy link
Contributor

@ECL314 ECL314 commented Oct 16, 2019

I have edited my BCO per the two issues (#103 & #112 ) from @jpat1546
My BCO is ready for review. – Could you please verify that those two issues have been properly resolved in this version of my BCO?

However, I would like to tweak my BCO a little more before submitting to the pFDA challenge, and I will be sure to have all changes made for FINAL review before the Thursday 5PM deadline.

I have edited my BCO per the two issues (#103 & #112 ) from @jpat1546 
My BCO is ready for review.  – Could you please check that those two issues have been properly resolved in this version of my BCO?  

However, I would like to tweak my BCO a little more before submitting to the pFDA challenge, and I will be sure to have all changes made for final review before the Thursday 5PM deadline.
@ECL314 ECL314 added this to the Final BCO milestone Oct 16, 2019
@ECL314 ECL314 changed the title Update and rename Elizabeth_Lee_BCO_000516 to Elizabeth_Lee_BCO_000548 Upload Elizabeth_Lee_BCO_000548 Oct 16, 2019
@ECL314 ECL314 changed the title Upload Elizabeth_Lee_BCO_000548 Upload E.Lee BCO Oct 16, 2019
@jpat1546 jpat1546 self-requested a review October 16, 2019 23:03
Copy link
Collaborator

@jpat1546 jpat1546 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your BCO is approved

Great job fixing all your assigned issues, Elizabeth.
Prior to submitting to the pFDA challenge, please make the following 2 changes to your BCO in the BCO Editor (then download and submit to the pFDA):

In Provenance domain:

  1. Change reviewer status from "in-review" to "approved"
  2. Change reviewer_comment from "Reviewed by BioCompute technical assistant, approval pending modification by author" to "Reviewed and approved by BioCompute technical assistant."

Leave me a comment if these instructions are not clear. Thanks!

@jpat1546 jpat1546 merged commit 18b8b29 into master Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants