-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload D.Cao BCO #192
Upload D.Cao BCO #192
Conversation
ready for review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed your updated BCO and made comments on what further needs to be fixed. (no new issues- just existing ones that weren't addressed in your update). Please make all the changes in the BCO Editor, download, and update this pull request file with the new JSON (copy/paste- same process as before). Once all changes have been made, assign this pull request back to me and I will review again. Until then, assigning the pull request back to you.
Great job with those modifications- of the 9 issues assigned to you, only 2 are left to be fixed!
"orcid": "", | ||
"affiliation": "Department of Medicinal Chemistry, College of Pharmacy, Rogel Cancer Center, University of Michigan, Ann Arbor", | ||
"contribution": [ | ||
"authoredBy" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to "authoredBy", each publication author should also have the "derivedFrom" contribution type.
Please add. See #112
"orcid": "", | ||
"affiliation": "Department of Computational Medicine and Bioinformatics, University of Michigan, Ann Arbor ; Department of Biostatistics, School of Public Health, University of Michigan, Ann Arbor", | ||
"contribution": [ | ||
"authoredBy" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to "authoredBy", each publication author should also have the "derivedFrom" contribution type. Please add. See #112
"orcid": "https://orcid.org/0000-0003-1553-6695", | ||
"affiliation": "Departments of Radiation Oncology, Rogel Cancer Center, University of Michigan Medical School and Department of Environmental Health Sciences, School of Public Health, University of Michigan, Ann Arbor", | ||
"contribution": [ | ||
"authoredBy" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to "authoredBy", each publication author should also have the "derivedFrom" contribution type. Please add. See #112
"orcid": "https://orcid.org/0000-0003-3291-7131", | ||
"affiliation": "Department of Medicinal Chemistry, College of Pharmacy, Rogel Cancer Center, University of Michigan, Ann Arbor", | ||
"contribution": [ | ||
"authoredBy" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to "authoredBy", each publication author should also have the "derivedFrom" contribution type. Please add. See #112
] | ||
}, | ||
"usability_domain": [ | ||
"Adapted from Tiangong Lu, Armand Bankhead, III, Mats Ljungman, Nouri Neamati. \"Multi-omics profiling reveals key signaling pathways in ovarian cancer controlled by STAT3.\" PMC6735387(July 28, 2019). https://www.ncbi.nlm.nih.gov/pmc/articles/PMC6735387/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While it's great that you included a sentence on which publication this BCO was adapted from, there also needs to be more information in this usability domain. See #122 for more information on what goes in here.
closed by #250 |
ready for review